Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing voices at clickwaits and other voice issues #173

Open
3 of 5 tasks
drojf opened this issue Jan 7, 2023 · 0 comments
Open
3 of 5 tasks

Missing voices at clickwaits and other voice issues #173

drojf opened this issue Jan 7, 2023 · 0 comments
Labels

Comments

@drojf
Copy link
Contributor

drojf commented Jan 7, 2023

It seems kan_2e529 is supposed to play at the clickwait here. I checked the audio file (voice\16\20600529.ogg) and confirmed that it matches the text (あいつはそうするとはっきり僕に言ったよ。).

advchar "16"
langjp:dwave_jp 0, kan_2e528:「…あいつはお館様の財産を独り占めするために、台風が過ぎ去るまでに、どんな手を使ってでも皆殺しにする気なんだ。@あいつはそうするとはっきり僕に言ったよ。」\
;<嘉音
langen:dwave_eng 0, kan_2e528:^"...She wants to kill everyone by any means necessary before the typhoon passes, so that she can have the Master's wealth all to herself.^@^  She told me that clearly."^\

could potentially be worth checking to see if all the voice labels defined in the script are actually used. I've noticed a couple instances
like this in the past where voices didn't play

Reported on experimental script, but probably affects normal script as well


voice\27\20701429.ogg missing from voice archives (need to check ps3 game to see if it actually exists)

anyway looks like I spoke too soon (bad habit of mine). the replacement line in this image is actually a replacement for the next line in the dialogue, which was also censored. so the bea_2e1429 line (You wanted him to hold you, didn't yooooooooooou?) really was skipped entirely by the ps3 version. so I wouldn't expect there to be a corresponding voice file.

still strange how there's a gap in the voice file sequence, though (between 20701428.ogg and 20701430.ogg)


found a mistake in the voices in episode 3. the voice clip but_3e302 was skipped

image


  • Check for voice files never used in game script
  • Check all voice files in script exist on disk (only if voice is actually used in game script!)
  • voice\27\20701429.ogg missing from voice archives (need to check ps3 game to see if it actually exists)
    • this file is missing from ps3 game files - likely censored
  • Fix above issue with missing kan_2e529 voice at clickwait
  • Fix above issue with missing but_3e302 and shifted voice files
@drojf drojf added the bug label Jan 7, 2023
@drojf drojf changed the title Missing voices at clickwaits Missing voices at clickwaits and other voice issues Jan 7, 2023
drojf added a commit that referenced this issue Mar 9, 2023
drojf added a commit that referenced this issue Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant