Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EVM prover code to support distinct statements #20

Closed
Nashtare opened this issue Feb 12, 2024 · 3 comments
Closed

Refactor EVM prover code to support distinct statements #20

Nashtare opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.

Comments

@Nashtare
Copy link
Collaborator

For the sake of maintaining both type-1 and type-2 provers (and possibly additional variants along the way), with minimal code duplication, as well as to facilitate any upgrade that would affect both versions, we need to prover to be modular enough and activate one instance over another through feature flags.

In particular, with respect to type-2, we need:

  • identify the distinct Kernel parts that need distinct handling
  • unify the entry / exit point of pieces that would have distinct logic (for instance mpt_trie vs smt_trie), i.e. identical stack modifications
  • tweak the proving code (cf extra PoseidonStark table and CTLs for instance). We may want to have a dedicated constant module with distinct versions inside, instead of the hardcoded (and possibly changing) values here and there (cf const NATIVE_INSTRUCTIONS: [usize; 13] for instance).
@Nashtare
Copy link
Collaborator Author

For this, I think we could do the work off the type2/hermez and against that branch, so that it can then be directly merged to main.

@Nashtare Nashtare transferred this issue from 0xPolygonZero/plonky2 Feb 13, 2024
@Nashtare Nashtare added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Feb 13, 2024
@Nashtare Nashtare added this to the Type 2 - Q1 2024 milestone Feb 13, 2024
@Nashtare Nashtare self-assigned this May 22, 2024
@Nashtare
Copy link
Collaborator Author

Assigning this to myself, though I'll wait for #31 to be merged into develop, then rebase #150 on top on top and start this work from it.

BGluth pushed a commit that referenced this issue Jun 17, 2024
Move away from git dependencies
@Nashtare Nashtare moved this from Todo to Backlog in Zero EVM Jul 9, 2024
@Nashtare Nashtare moved this from Backlog to Todo in Zero EVM Jul 9, 2024
@Nashtare
Copy link
Collaborator Author

Replaced by #561

@github-project-automation github-project-automation bot moved this from Todo to Done in Zero EVM Aug 28, 2024
@Nashtare Nashtare removed the status in Zero EVM Aug 28, 2024
@Nashtare Nashtare closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2024
@github-project-automation github-project-automation bot moved this to Done in Zero EVM Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

No branches or pull requests

2 participants