we shouldn't COPY .env . in our docker build

[0xaatif]

No description provided.

[BGluth]

Hmm... The .env is part of the project though. It should be included in the container somehow though eh?

[atanmarko]

@BGluth Problem is that you usually want to set environment variables for docker-compose or Kubernetes setup. I guess .env should be explicitly mounted? If you just copy it inside docker, wouldn't you effectively hardcode settings and overwrite devops environment setup?

[BGluth]

Ah makes sense, thanks.

We should also be a bit careful with the tool scripts doing stuff like this:

zk_evm/zero_bin/tools/prove_rpc.sh

Lines 20 to 37 in d02e150

	if [[ $8 == "test_only" ]]; then
	# Circuit sizes don't matter in test_only mode, so we keep them minimal.
	export ARITHMETIC_CIRCUIT_SIZE="16..17"
	export BYTE_PACKING_CIRCUIT_SIZE="9..10"
	export CPU_CIRCUIT_SIZE="12..13"
	export KECCAK_CIRCUIT_SIZE="14..15"
	export KECCAK_SPONGE_CIRCUIT_SIZE="9..10"
	export LOGIC_CIRCUIT_SIZE="12..13"
	export MEMORY_CIRCUIT_SIZE="17..18"
	else
	export ARITHMETIC_CIRCUIT_SIZE="16..23"
	export BYTE_PACKING_CIRCUIT_SIZE="9..21"
	export CPU_CIRCUIT_SIZE="12..25"
	export KECCAK_CIRCUIT_SIZE="14..20"
	export KECCAK_SPONGE_CIRCUIT_SIZE="9..15"
	export LOGIC_CIRCUIT_SIZE="12..18"
	export MEMORY_CIRCUIT_SIZE="17..28"
	fi

zk_evm/zero_bin/tools/prove_stdio.sh

Lines 44 to 73 in d02e150

	if [[ $TEST_ONLY == "test_only" ]]; then
	# Circuit sizes don't matter in test_only mode, so we keep them minimal.
	export ARITHMETIC_CIRCUIT_SIZE="16..17"
	export BYTE_PACKING_CIRCUIT_SIZE="9..10"
	export CPU_CIRCUIT_SIZE="12..13"
	export KECCAK_CIRCUIT_SIZE="14..15"
	export KECCAK_SPONGE_CIRCUIT_SIZE="9..10"
	export LOGIC_CIRCUIT_SIZE="12..13"
	export MEMORY_CIRCUIT_SIZE="17..18"
	else
	if [[ $INPUT_FILE == *"witness_b19240705"* ]]; then
	# These sizes are configured specifically for block 19240705. Don't use this in other scenarios
	echo "Using specific circuit sizes for witness_b19240705.json"
	export ARITHMETIC_CIRCUIT_SIZE="16..19"
	export BYTE_PACKING_CIRCUIT_SIZE="16..19"
	export CPU_CIRCUIT_SIZE="18..21"
	export KECCAK_CIRCUIT_SIZE="15..18"
	export KECCAK_SPONGE_CIRCUIT_SIZE="10..13"
	export LOGIC_CIRCUIT_SIZE="13..17"
	export MEMORY_CIRCUIT_SIZE="20..23"
	else
	export ARITHMETIC_CIRCUIT_SIZE="16..23"
	export BYTE_PACKING_CIRCUIT_SIZE="9..21"
	export CPU_CIRCUIT_SIZE="12..25"
	export KECCAK_CIRCUIT_SIZE="14..20"
	export KECCAK_SPONGE_CIRCUIT_SIZE="9..15"
	export LOGIC_CIRCUIT_SIZE="12..18"
	export MEMORY_CIRCUIT_SIZE="17..28"
	fi
	fi

[atanmarko]

We should also be a bit careful with the tool scripts doing stuff like this:

In general I agree but these are just scripts for testing so no big deal I think :)

[0xaatif]

Fixed in #357