Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor geometry types #11

Open
Tracked by #30
Ylannl opened this issue Apr 24, 2024 · 0 comments
Open
Tracked by #30

Refactor geometry types #11

Ylannl opened this issue Apr 24, 2024 · 0 comments

Comments

@Ylannl
Copy link
Member

Ylannl commented Apr 24, 2024

  • Geometry types should not inherit from std::vector, this is not good practice
  • should however implement a similar interface to std::vector, with size(), begin(), end(), front(), back(), operator etc
  • use contiguous memory for coordinates
  • maybe make number type (float, double) a template parameter (???)
  • name the geometry types in accordance with CityJSON? or WKT? (poincloud, segments, linestring, surface (polygon), solid)
  • how to handle semantics for solids?
@Ylannl Ylannl added this to the roofer v1.0 milestone Apr 24, 2024
@Ylannl Ylannl mentioned this issue Apr 24, 2024
37 tasks
@Ylannl Ylannl modified the milestones: roofer v1.0, Code Refactor Apr 24, 2024
@Ylannl Ylannl mentioned this issue Jul 31, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant