Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for correct URL for public vs private repos #159

Open
aidanheerdegen opened this issue Nov 12, 2024 · 1 comment
Open

Check for correct URL for public vs private repos #159

aidanheerdegen opened this issue Nov 12, 2024 · 1 comment
Labels
enhancement New feature or request priority:low

Comments

@aidanheerdegen
Copy link
Member

Private GitHub repos should use [email protected]:org/repo.git URLs, whereas https URLs are preferred for public repos.

This was highlighted in this issue

#155

which broke automated CI style builds that rely on SSH keys to access a private repo.

It should be possible to add a CI QA test to check the code URLs and make sure https is used for public GitHub repos, and git URLs for private.

@aidanheerdegen aidanheerdegen added enhancement New feature or request priority:low labels Nov 12, 2024
@penguian
Copy link
Contributor

See in partcular issue #158 which asks to revert pull request #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low
Projects
Status: New Issues 🌅
Development

No branches or pull requests

2 participants