Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Contribution to Refactoring Codebase to Gradle Convention Plugin #78

Open
VahidGarousi opened this issue Sep 21, 2023 · 6 comments

Comments

@VahidGarousi
Copy link

VahidGarousi commented Sep 21, 2023

Hello! I'm interested in contributing to the project titled 'Refactoring Codebase to Gradle Convention Plugin: Enhancing Build Efficiency and Maintainability.' I've reviewed the project's goals, I believe I can make valuable contributions to this effort.

Before I start working on any changes, I wanted to discuss this with you to ensure my contributions align with the project's goals and roadmap. I'd appreciate any guidance or information you can provide to get started.

Looking forward to your feedback!

@VahidGarousi
Copy link
Author

@AdamMc331 did you read this issue?

@AdamMc331
Copy link
Owner

Can you share some resources on this plugin you're referring to?

@VahidGarousi
Copy link
Author

VahidGarousi commented Nov 5, 2023

https://github.com/Kaaveh/ComposeNews/tree/kmp/build-logic

Mastering Dependency Management: Version Catalog & Convention Plugin at Scale 🚀 https://medium.com/proandroiddev/mastering-android-dependency-management-b94205595f6b

@AdamMc331
Copy link
Owner

@VahidGarousi Thanks for sharing! I'm open to changes in this template, but I want to understand a little more about what specifically we're changing. For example, this project already uses Gradle Version Catalogs.

So I think the suggestion here is specifically the Gradle Convention Plugin, which is helpful if this project were to scale up to multiple modules as we could reduce boilerplate across different modules?

@VahidGarousi
Copy link
Author

@AdamMc331
Yes, you're correct! The Gradle Convention Plugin can be beneficial for this project, especially if you plan to scale up to multiple modules. It helps reduce boilerplate code across different modules by applying consistent conventions. It allows you to define common configurations and settings in one place, making it easier to manage and maintain this project as it grows. This approach enhances consistency and streamlines the development process across modules.

@AdamMc331
Copy link
Owner

That makes sense! I'm not super familiar with it, if you'd like to make a PR we can discuss it more then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants