Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook notifications are accepted when they should not be accepted #1230

Open
wouterwp opened this issue Dec 19, 2024 · 1 comment
Open

Comments

@wouterwp
Copy link

wouterwp commented Dec 19, 2024

If a webhook notification sent by Adyen cannot be authenticated due to incorrect Basic of HMAC authentication then the adyen/error.isml template is rendered (here), but since this response uses a successful HTTP status code Adyen will consider this notification as accepted.

Also if another issue occurs when string the webhook notification then the notifyError.isml template is rendered (here), but again with a successful HTTP status code so Adyen will also consider this notification as accepted.

See also https://www.adyen.com/knowledge-hub/webhooks-accept-2xx

Considering these notifications as accepted by Salesforce Commerce Cloud means that merchants will not be properly informed that notifications are in fact not configured correctly, and can lead to orders not being placed.

@amihajlovski
Copy link
Contributor

Hello @wouterwp

We are already looking into this.

Kind Regards,
Aleksandar
Adyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants