Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required changes for a unified Ti.PayPal module (Parity) #8

Open
5 tasks
hansemannn opened this issue May 24, 2017 · 1 comment
Open
5 tasks

Required changes for a unified Ti.PayPal module (Parity) #8

hansemannn opened this issue May 24, 2017 · 1 comment

Comments

@hansemannn
Copy link
Contributor

Hey @AppWerft,

let's write up a list of parity-changes required to move the iOS and Android version together:

  • Rename initPayment to initialize
  • Remove the ability to store keys in the tiapp.xml (security reasons, the keys are not encrypted I think) - No blocker
  • Require the configuration key to be an instance of the Configuration proxy (no object, to keep it more structured and be able to hook into possible events that will be exposed in the future)
  • Require the items key to be an array of the PaymentItem proxy instances (see above reasons). I noticed there is no PaymentItem proxy so far, so if possible, create that one for parity
  • Ensure all events from iOS also exist on Android or list the ones that are not covered. Some examples of important events: paymentDidCancel , paymentWillComplete and paymentDidComplete (For example, I don't see paymentWillComplete in the Android docs so far)

Thank you so much for the efforts! It will be amazing to have a centralized and up-to-date PayPal module for the developers again!

@AppWerft
Copy link
Owner

AppWerft commented May 24, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants