Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Weather Map condition codes have changed #16

Open
eLtMosen opened this issue Apr 11, 2022 · 3 comments
Open

Open Weather Map condition codes have changed #16

eLtMosen opened this issue Apr 11, 2022 · 3 comments
Assignees

Comments

@eLtMosen
Copy link
Member

The icon.js contains weather condition codes that are not available on OWM anymore.
This was a state that reflects what we have in icon.js
http://web.archive.org/web/20150215065518/https://openweathermap.org/weather-conditions

Here are the to be adapted recent codes
https://openweathermap.org/weather-conditions

@eLtMosen
Copy link
Member Author

Dodoradio kindly adapted the icon.js to the new OWM codes and added a drizzle icon.

There is an unsused state for fog/sandstom/mist.

Keeping this issue open until we came up with a new icon for that.

@Senjosei
Copy link

Are we sticking to the iOS styled icons? Because if not theres a very good weather icon library thats almost 1:1 to OWM weather conditions and its MIT licensed. https://github.com/basmilius/weather-icons

@eLtMosen
Copy link
Member Author

That is a very good observation, kudos!
I think the outlined Meteocons pair reasonably well with the rest of the iOS system icons.
The only "clash" i could see is the weather app icon itself, since that is now just the ios cloud outline.
The Meteocons have a tad thicker line-width than the iOS ones, So a weather-app-icon change to Meteocon clouds would definitely look inconsistent when in an applauncher.
Imo, that should not hinder us to beautify the actual weather icons within the weather app however.
I am very much for this change. I made colorized versions of the iOS icons but never gotten around implementing them.
A push forward in that regard is highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants