Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted gc_details in Go pack #1307

Open
azdanov opened this issue Jan 4, 2025 · 2 comments
Open

Deleted gc_details in Go pack #1307

azdanov opened this issue Jan 4, 2025 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@azdanov
Copy link

azdanov commented Jan 4, 2025

Is your feature related to a problem?

New version of gopls has deleted this option:

gc_details = true, -- Show a code lens toggling the display of gc's choices.

https://github.com/golang/tools/blob/master/gopls/doc/release/v0.18.0.md#configuration-changes

The gc_details code lens has been deleted. (It was previously disabled by default.) This functionality is now available through the settings.toggleCompilerOptDetails code action (documented below), as code actions are better supported than code lenses across a range of clients.

Describe the new feature

Should it be removed or migrated toggleCompilerOptDetails?

Additional context

No response

@azdanov azdanov added the enhancement New feature or request label Jan 4, 2025
@azdanov azdanov changed the title Migrate gc_details in Go pack Deleted gc_details in Go pack Jan 4, 2025
@Uzaaft
Copy link
Member

Uzaaft commented Jan 5, 2025

Lets migrate it.

@azdanov
Copy link
Author

azdanov commented Jan 5, 2025

https://cs.opensource.google/go/x/tools/+/refs/tags/gopls/v0.17.1:gopls/doc/releases.md

Based on this approximate schedule it's not urgent at the moment. Somewhere around March - April, I guess.

@mehalter mehalter added the good first issue Good for newcomers label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants