Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms Block: Multiple Choice blocks can overlay the "Add Block" button on mobile #32695

Closed
dpasque opened this issue Aug 25, 2023 · 5 comments
Closed
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. Groundskeeping Worked on by Dotcom Groundskeeping [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dpasque
Copy link
Contributor

dpasque commented Aug 25, 2023

Impacted plugin

Jetpack

Quick summary

There seems to be a CSS z-index problem when you're on a mobile viewport and working with a Multiple Choice block within a Form block. In short, if the Multiple Choice block is the last block in the form, and you target the parent Form Block, you can't actually click the inline "Add Block" button because there's a really high z-index overlay that's blocking you.

Screenshot 2023-08-25 at 1 33 28 PM

Steps to reproduce

  1. Add a Form block in the editor
  2. Add a Multiple Choice block to the end
  3. Select the parent block
  4. Try to click the inline "Add Block" button -- you'll instead just focus the Multiple Choice block

A clear and concise description of what you expected to happen.

You can click the inline Add Block button.

What actually happened

You just focus the Multiple Choice block anyway

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

No response

@dpasque dpasque added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form [Pri] Low [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] Contact Form Form block (also see Contact Form label) Needs triage Ticket needs to be triaged [Product] Jetpack [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Aug 25, 2023
@cuemarie
Copy link

cuemarie commented Aug 29, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Could Not Replicate
  • Tested on Atomic – Could Not Replicate

See updated notes below.

📌 FINDINGS/SCREENSHOTS/VIDEO
I was not able to replicate the behavior described- but my test results showed some unexpected behavior as well (the inline block pop up appearing far out of place).

Atomic
https://github.com/Automattic/jetpack/assets/27249804/2e895e80-fc30-4e2b-b0d6-eb315e597435

Simple
https://github.com/Automattic/jetpack/assets/27249804/9f1c6d03-5623-4dc0-a59b-d3dba3bbabd1

📌 ACTIONS

  • Requested author feedback
  • CC: @jeherve

📌 Message to Author
@dpasque in what browser did you see the behavior reported? I was using Firefox 116.0.3 for my tests 🤔

@cuemarie cuemarie added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 29, 2023
@dpasque
Copy link
Contributor Author

dpasque commented Aug 30, 2023

@cuemarie -- huh, weird! 🤔

I was using chrome, but I was just able to reproduce in Firefox too. 🙃 I was using the actual developer tools mobile emulator vs the editor preview mobile emulator, in case that makes a difference?

Here's a gif!

button-overlay-form

@cuemarie cuemarie removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 30, 2023
@cuemarie
Copy link

Thanks @dpasque ! I thought I'd tried that as well, but I retested today and can see the same issue you're reporting in both Chrome and Firefox :) Appreciate the clarification!

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

UYJgjL.mp4

📌 ACTIONS

  • Triage complete

@cuemarie cuemarie moved this from Needs Triage to To Do in Automattic Prioritization: The One Board ™ Aug 30, 2023
@cuemarie cuemarie added Triaged and removed Needs triage Ticket needs to be triaged labels Aug 30, 2023
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This issue has been marked as stale. This happened because:

  • It has been inactive for the past 6 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@davemart-in davemart-in added the Groundskeeping Worked on by Dotcom Groundskeeping label Oct 15, 2024
@enejb
Copy link
Member

enejb commented Jan 17, 2025

I wasn't able to replicate this issue. So I am marking as fixes.

From my investigation the z-index is also set correctly see.

Image

@cuemarie and @dpasque feel free to reopen the issue if you are able to replicate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. Groundskeeping Worked on by Dotcom Groundskeeping [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

5 participants