[tsp-client convert] Error "invalid-ref: Unknown identifier AadOauth2Auth" converting contosowidgetmanager/data-plane

[mikeharder]

Using @azure-tools/[email protected] and @autorest/[email protected], converting contosowidgetmanager/data-plane fails with an error compiling the generated code:

$ mkdir specification/contosowidgetmanager/Test.TspClientConvert
$ npx tsp-client convert --no-prompt --swagger-readme specification/contosowidgetmanager/data-plane/readme.md -o specification/contosowidgetmanager/Test.TspClientConvert

$ npx tsp compile specification/contosowidgetmanager/Test.TspClientConvert
specification/contosowidgetmanager/Test.TspClientConvert/main.tsp:20:10 - error invalid-ref: Unknown identifier AadOauth2Auth
> 20 | @useAuth(AadOauth2Auth<["https://contoso.azure.com/.default"]>)
     |          ^^^^^^^^^^^^^

data-plane test in azure-rest-api-specs is currently disabled due to this issue:

https://github.com/Azure/azure-rest-api-specs/blob/main/eng/tools/tsp-client-tests/test/tsp-client.test.ts#L75

[pshao25]

@mikeharder I think we have some miscommunication here. @ArthurMa1978 yesterday replied in the email that we think

Running conversion tests on the spec repo is not ideal, as it is a post-check that cannot catch issues immediately. Additionally, conversion is not a common action for TSP upgrades.

Can we understand the reason why we add this test in specs repo but not converter repo?

[mikeharder]

For now, I'll standardize on using Contoso in the specs repo as an acceptance test.

I think you adding the same test to the converter repo is a great idea.

Once the test is working in your repo, you can close this issue which will notify me to re-enable the test in the specs repo.

[pshao25]

@mikeharder The swagger is not a good one. Look at this operation. Manually, I think it should be deleteWidget is Azure.Core.LongRunningResourceDelete<WidgetSuite>; But in this whole operation, there is no place you could find a thing called WidgetSuite. Then how could converter know the response is WidgetSuite?

I saw your swagger is a generated one from TypeSpec. I think this is a roundtrip case need to discussion with TypeSpec team.