Cancelling an image upload in building management is not handled

[bryantal]

Original report by Scott Heggen (Bitbucket: sheggen, GitHub: sheggen).

---

Files: buildingManagement.py

UI: /buildingManagement

When a user is in the process of uploading an image using the Dropzone widget, they have the choice to cancel the upload while it’s in progress. Our controller doesn’t handle this issue, but instead throws a 400 bad request error. The error has no negative impact on the application, as far as I could tell.

[Ebenezer997]

test the canceling of the image upload and we did not get the 400 error. We believe the issue is already solved

[sheggen]

@Ebenezer997 's DDS reported that no images are ever deleted from CAS when they are removed in the buildingmanagement UI. That is an implementation error, and should be fixed; removing an image should... remove the image!

This will need implemented in multiple places: the JS handler for dropzone will need to implement the correct configuration for allowing remote deletion of files. The controller file will need a route for deleting files. The file will need removed + reference to it in the DB removed. The controller will need to gracefully handle missing files (e.g., someone deletes the file on the server manually).

A bigger issue that needs discussed in the morning meeting will be handling of images; they probably shouldn't be in the repo, since the images are "data", not part of the codebase.

Lastly, as design and implementation of this fix is considered, so should the security of the system. A controller that arbitrarily deletes any file that is sent to it would be a major security problem. Be mindful of security!