Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum total budget for a proposal changes from year to year #186

Open
sheggen opened this issue Jan 3, 2023 · 1 comment
Open

Maximum total budget for a proposal changes from year to year #186

sheggen opened this issue Jan 3, 2023 · 1 comment

Comments

@sheggen
Copy link
Contributor

sheggen commented Jan 3, 2023

Faculty stipends (which is solved by PR #183) brings about another issue, which is there is a warning hard-coded into the end of the proposal form which notifies the user that their proposal is over a certain amount: https://github.com/BCStudentSoftwareDevTeam/urcpp/blob/development/api/templates/pages/budget.html#L133

This number should be dynamic, which means it needs to be programmable in the Set Parameters page.

However, the current number ($8300) was derived from a $5300 faculty stipend (now wrong) + $3000 max budget for everything else (which may also change in the future). Worse yet, this doesn't take into consideration the fact that two or more faculty could be on a proposal, which would make the budget: 5300 + 5300 + 3000.

So, this needs reworked so that faculty stipends are treated separately from the other budget calculations when this warning is displayed. In reality, it should only be a check on the $3000 budget for everything else, and a separate check on the stipend based on the number of faculty on the proposal.

Both the stipend and the "everything else budgets" should be set in the Set Parameters page so they can change each year.

You'll also want to check the impact of this on previous years (i.e., fix the production data so the value is in there).

@sheggen
Copy link
Contributor Author

sheggen commented Jan 16, 2025

This issue appears in multiple places related to budget. On the pages/budget.html page, as well as the summary page described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant