-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request]: GD support for image generation #137
Comments
There is an open pull requests for an alternate |
@elnath78 as noted above, there is open PR for that. If you want, add this to your P.S. There is another reason not to use Imagick. When QR code is too large it was failing for me locally with some kind a weird exception that the path was too complex. "repositories": [
{
"type": "vcs",
"url": "https://github.com/arxeiss/BaconQrCode"
}
],
"require": {
...
"bacon/bacon-qr-code": "dev-add-gd-backend#650e10121f4d8707ecdc5984b042cae7731e388a", |
@arxeiss I tried the Bacon path but it is incredibly slow, tested on local and it averaged 1.76 seconds to generate a QR code, I tested the various available formats. Eventually I decided to use the Google service for QR Code generation, and although it does a remote connection, it is super fast, the average was 0.08 seconds. The only concern is about GDPR, the other possible solution would be generate QR Codes then serve them as users join and request them, possibly an async service that generate a QR Code when the user signs up and serve it ready when he decides to switch to 2FA login. |
How big your QR code is?
|
@arxeiss
|
Resolved by #171 |
I'm not sure ifthis was already discussed, but I find much more practical to have GD support than Imagick, iirc GD is natively present in recent PHP intallations, while Imagick must be installed separately, configured and you need to pray it works.
The text was updated successfully, but these errors were encountered: