Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No matter what I use during make the process always crashes #286

Open
TomerGamerTV opened this issue Nov 14, 2024 · 10 comments
Open

No matter what I use during make the process always crashes #286

TomerGamerTV opened this issue Nov 14, 2024 · 10 comments

Comments

@TomerGamerTV
Copy link

Even on my mac or github actions the process crashes when running make...

Github Log: https://github.com/TomerGamerTV/BHTwitter/actions/runs/11835852844/job/32979515131

❯ ./build.sh --rootless
Building BHTwitter project for Rootless.
==> Cleaning…
> Making clean in libflex…
==> Cleaning…
> Making all for tweak BHTwitter…
==> Preprocessing Tweak.x…
==> Compiling BHTBundle/BHTBundle.m (arm64)…
==> Compiling BHDownload/BHDownload.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDAnimation.m (arm64)…
==> Compiling Colours/Colours.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUD.m (arm64)…
==> Compiling BHTManager.m (arm64)…
==> Compiling BHDownloadInlineButton.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDErrorIndicatorView.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDFadeAnimation.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDFadeZoomAnimation.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDImageIndicatorView.m (arm64)…
==> Compiling SettingsViewController.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDIndeterminateIndicatorView.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDShadow.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDIndicatorView.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDPieIndicatorView.m (arm64)…
==> Compiling SAMKeychain/SAMKeychain.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDRingIndicatorView.m (arm64)…
==> Compiling JGProgressHUD/JGProgressHUDSuccessIndicatorView.m (arm64)…
==> Compiling SAMKeychain/SAMKeychainQuery.m (arm64)…
==> Compiling SAMKeychain/AuthViewController.m (arm64)…
==> Compiling SAMKeychain/keychain.m (arm64)…
==> Compiling CustomTabBar/BHCustomTabBarItem.m (arm64)…
==> Compiling AppIcon/BHAppIconItem.m (arm64)…
==> Compiling CustomTabBar/BHCustomTabBarSection.m (arm64)…
==> Compiling AppIcon/BHAppIconCell.m (arm64)…
==> Compiling CustomTabBar/BHCustomTabBarUtility.m (arm64)…
==> Compiling AppIcon/BHAppIconViewController.m (arm64)…
==> Compiling CustomTabBar/BHCustomTabBarViewController.m (arm64)…
==> Compiling ThemeColor/BHColorThemeItem.m (arm64)…
==> Compiling ThemeColor/BHColorThemeCell.m (arm64)…
==> Compiling ThemeColor/BHColorThemeViewController.m (arm64)…
==> Compiling Tweak.x (arm64)…
Tweak.x:554:43: error: use of undeclared identifier 'kUTTypeMovie'
  554 |     videoPicker.mediaTypes = @[(NSString*)kUTTypeMovie];
      |                                           ^
Tweak.x:663:27: warning: assigning to 'T1StatusCell *__strong' from incompatible type 'id<TTACoreStatusViewEventHandler>'
  663 |                 tweetView = [(T1StandardStatusView *)actionsView.superview eventHandler];
      |                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tweak.x:665:27: warning: assigning to 'T1StatusCell *__strong' from incompatible type 'id<TTACoreStatusViewEventHandler>'
  665 |                 tweetView = [(T1TweetDetailsFocalStatusView *)actionsView.superview eventHandler];
      |                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tweak.x:667:27: warning: assigning to 'T1StatusCell *__strong' from incompatible type 'id<TTACoreStatusViewEventHandler>'
  667 |                 tweetView = [(T1ConversationFocalStatusView *)actionsView.superview eventHandler];
      |                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tweak.x:691:40: warning: initializing 'T1StatusInlineActionsView *__strong' with an expression of incompatible type 'id<T1StatusInlineActionButtonDelegate>'
  691 |             T1StatusInlineActionsView *actionsView = self.delegate;
      |                                        ^             ~~~~~~~~~~~~~
Tweak.x:695:27: warning: assigning to 'T1StatusCell *__strong' from incompatible type 'id<TTACoreStatusViewEventHandler>'
  695 |                 tweetView = [(T1StandardStatusView *)actionsView.superview eventHandler];
      |                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tweak.x:697:27: warning: assigning to 'T1StatusCell *__strong' from incompatible type 'id<TTACoreStatusViewEventHandler>'
  697 |                 tweetView = [(T1TweetDetailsFocalStatusView *)actionsView.superview eventHandler];
      |                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tweak.x:699:27: warning: assigning to 'T1StatusCell *__strong' from incompatible type 'id<TTACoreStatusViewEventHandler>'
  699 |                 tweetView = [(T1ConversationFocalStatusView *)actionsView.superview eventHandler];
      |                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
7 warnings and 1 error generated.
make[3]: *** [/Users/tomer/theos/makefiles/instance/rules.mk:404: /Users/tomer/Downloads/BHTwitter/.theos/obj/debug/arm64/Tweak.x.ea62ce25.o] Error 1
rm /Users/tomer/Downloads/BHTwitter/.theos/obj/debug/arm64/Tweak.x.m
make[2]: *** [/Users/tomer/theos/makefiles/instance/library.mk:52: /Users/tomer/Downloads/BHTwitter/.theos/obj/debug/arm64/BHTwitter.dylib] Error 2
make[1]: *** [/Users/tomer/theos/makefiles/instance/library.mk:37: internal-library-all_] Error 2
make: *** [/Users/tomer/theos/makefiles/master/rules.mk:146: BHTwitter.all.tweak.variables] Error 2
Done, thanks for using BHTwitter.

This didnt actually output any files

@starkayc
Copy link

Update TWHeaders.h with the changes in this PR #282 and it should work.

@TheKivster
Copy link

Update TWHeaders.h with the changes in this PR #282 and it should work.

How does one do that?

@TomerGamerTV
Copy link
Author

Update TWHeaders.h with the changes in this PR #282 and it should work.

How does one do that?

Grab the change from his PR request and replace it in your TWHeaders.h file with what he replaced in the PR request

@starkayc
Copy link

starkayc commented Dec 2, 2024

Update TWHeaders.h with the changes in this PR #282 and it should work.

How does one do that?

2024-12-02.13-31-18.mp4

After you done that, you should be able to run build in actions tab. Hope that helps :D

@TomerGamerTV
Copy link
Author

Is this path correct when injecting the Deb file? image

@starkayc
Copy link

starkayc commented Dec 2, 2024

Is this path correct when injecting the Deb file? image

If you're sideloading then you can just use the actions build to have it inject it. Just set deployment as "sideloaded" But, yes that's the correct path if you're injecting a deb (at least to my knowledge).
image

@TheKivster
Copy link

Update TWHeaders.h with the changes in this PR #282 and it should work.

How does one do that?

2024-12-02.13-31-18.mp4

After you done that, you should be able to run build in actions tab. Hope that helps :D

It works. Thank you so much!

@TomerGamerTV
Copy link
Author

TomerGamerTV commented Dec 3, 2024

Is this path correct when injecting the Deb file? image

If you're sideloading then you can just use the actions build to have it inject it. Just set deployment as "sideloaded" But, yes that's the correct path if you're injecting a deb (at least to my knowledge). image

I tried injecting the deb file but twitter keeps crashing even with sideload fix injected... i will try exporting the IPA in github but i have my doubts it will work

Edit: Seems like using the sideload option worked, idk what changed exactly but I'm gonna try the debug Deb file it gave me and check if it works

@TheKivster
Copy link

Update TWHeaders.h with the changes in this PR #282 and it should work.

How does one do that?

2024-12-02.13-31-18.mp4

After you done that, you should be able to run build in actions tab. Hope that helps :D

Does changing the target iOS version actually do anything?

@TomerGamerTV
Copy link
Author

Update TWHeaders.h with the changes in this PR #282 and it should work.

How does one do that?

2024-12-02.13-31-18.mp4

After you done that, you should be able to run build in actions tab. Hope that helps :D

Does changing the target iOS version actually do anything?

It sets the minimum iOS version that can open the app, just leave it like that if everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants