New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win log requester marks warnings incorrectly #4

Open

spencer-sullivan opened this issue Aug 5, 2016 · 1 comment

spencer-sullivan commented Aug 5, 2016

When running the win log requester, it marks every successful request as a warning because of the line:

if response.status_code != 200 or response.status_code != 204:

in beeswax/tools/win_events/win_log_requester.py:153

The fix for this would be to change it to be an and instead of an or.

The text was updated successfully, but these errors were encountered:

RonRothman commented Aug 5, 2016 •

edited

Loading

Nice catch.

I'd suggest:

if response.status_code not in {200, 204}:

We'll make the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment