Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Update ayon_lop_import 1.0 (Expanded HDA) #9

Conversation

MustafaJafar
Copy link

Changelog Description

update ayon_lop_import 1.1: Allow users to select folder path and products using some actions

Animation_45

@MustafaJafar
Copy link
Author

Also, let me add my concern about the parameter Representation .
This concern came from re-using the logic for other product types.
Here's a snippet.

project_name = "some project name"
folder_path = "some folder path"
representation_name = "pointcache"

folder_entity = ayon_api.get_folder_by_path(project_name,
                                                folder_path,
                                                fields={"id"})

products = ayon_api.get_products(
        project_name,
        folder_ids=[folder_entity["id"]],
        product_types=[representation_name]
    )

Copy link
Owner

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff - some comments in the review.

server_addon/houdini/client/ayon_houdini/api/hda_utils.py Outdated Show resolved Hide resolved
server_addon/houdini/client/ayon_houdini/api/hda_utils.py Outdated Show resolved Hide resolved
server_addon/houdini/client/ayon_houdini/api/hda_utils.py Outdated Show resolved Hide resolved
server_addon/houdini/client/ayon_houdini/api/hda_utils.py Outdated Show resolved Hide resolved
server_addon/houdini/client/ayon_houdini/api/hda_utils.py Outdated Show resolved Hide resolved
@MustafaJafar MustafaJafar changed the title Houdini: Update ayon_lop_import 1.1 (Expanded HDA) Houdini: Update ayon_lop_import 1.0 (Expanded HDA) Jun 10, 2024
@MustafaJafar MustafaJafar requested a review from BigRoy June 10, 2024 16:00
@MustafaJafar
Copy link
Author

Just for reference.

  1. the folder dialog will be empty until the publisher tool is triggered (as it does some initializations).
    image
  2. the folder dialog only works with the current project as mentioned in the TODO inside select_folder_path function, however, users are free to edit the folderpath parameter manually.
    image

@MustafaJafar MustafaJafar requested a review from BigRoy June 10, 2024 16:11
Copy link
Owner

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - still some work to be done, but perfect prototype and other fixes can be implemented upstream.

@BigRoy BigRoy merged commit 5529beb into BigRoy:enhancement/houdini_load_asset_lop Jun 10, 2024
4 of 6 checks passed
BigRoy pushed a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants