Explore map page failing

[andrewvanbreda]

The UKBMS "Explore map" page is not working (accessed through "My data" menu).
https://ukbms.org/explore-map

The map does not show and grid is not populated.

Two errors in Firefox's development tools consoles

"Uncaught SyntaxError: missing name after . operator"
this refers to an area of code in helper_base in the area of line 166
"formatItem: {formatFunction}"

also another problem in reportFilters.js
"Uncaught TypeError: can't access property "cannotDeselectAllLicences", indiciaData.lang.reportFilters is undefined"
(around line 403)

Hi @BirenRathod

I have not managed to work out what is causing this yet, but I notice my old multidev site does not have the issue.
I THINK it is problem with the latest iForm code.
Can I check what was done to fix the site after the trouble with John's merge recently?
Was the site completely reversed to its previous state, or was the problem with the merge just patched in the area you 2 were experiencing the issue?
Also, what can I do to the live site that won't interfere with your future upstream Indicia updates? such as is it safe for me to take older versions of Indicia files and commit them onto live if it (temporarily) works around a problem.

Thanks for any assistance

[BirenRathod]

@andrewvanbreda I would suggest to ask John for exact detail but I know he had updated some js files in support to work with eu cookies.
Regarding eu cookies, I'm going to implement the eu cookies on all sites, so the John implementation of the code should work on all sites. so in regards to the older version of the code, it should not be advisable to use unless you got a plan to update it.

[andrewvanbreda]

@BirenRathod
OK, thanks for letting me know.

[andrewvanbreda]

I have worked out what has happened here.

I think the page has probably become broken after the merge that was done a few weeks ago.
I think the site is now running a combination of old and new code which is not working together very well in some cases.

@BirenRathod : I assume it is not possible to totally reverse back to the way the site was before that merge?
Assuming that isn't possible, I have removed the Explore Map option from the live site menu for now (there is no point it being there broken)

The page actually worsk once we update to the latest iForm code, however I have not finished testing that on my multidev site yet.
I did not previously realise it was ok on latest iForm because the iForm update on my multidev did hadn't worked properly without me realising. I have now correctly that situation, so can proceed further with testing.

[BirenRathod]

@andrewvanbreda do you want me to put site before that code merge? I could do on dev env but can't give guarantee if that same will work on test and live env. because there is no reverse pushing code mechanism on test and live.

I can only suggest that there are several changes made in this 985a04bc68 commit by John. you can find out of the files from "See Diff" link and make a note of those files and check once I push the code after reversing the commit.

I know it is lot of work and consider time but let me know if that sounds like a plan. Also, I need to check first if site works after putting the site before this 985a04bc68 merge.

[andrewvanbreda]

Hi @BirenRathod,
Thanks for the thoughts.

I think reading your notes there, it is probably better if we don't go that route, it sounds like a bit of a faff and could end up in a bit of a mess.
Also it would take time away from me testing the site on latest iForm.
I think because it is only one page that looks broken at the moment (as far as I know), I think best leave it until I finish testing the site with latest iForm.

I am testing the site with latest iForm on a multidev, and the testing is not going too badly at time of writing. Once done I will let you know and we can think about updating the live site.
That will fix the problem.

I will get back to you.

[BirenRathod]

@andrewvanbreda Using the latest code is the best approach and would help further for Drupal 11 update. I'm not proposing at present updating Drupal 11at present but it is worth to consider. The changes John made will help in that direction.

I hope fixing the problem is not massively pain for you.