Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling SQL DB to *pull* changes form the repo for updating a project #16

Open
BlackFoundry opened this issue Feb 15, 2021 · 7 comments

Comments

@BlackFoundry
Copy link
Member

or similar mechanism for taking into account changes made outside the SQL API.
A bit similar to the initial 'import' of ZIP .rcjk project but more flexible

@fabiocaccamo
Copy link
Member

fabiocaccamo commented Feb 15, 2021

@BlackFoundry we said that once the project were migrated to MySQL, the database would have kept the data centralized instead of git. Now this request goes in the opposite direction, why we would need this now?
Adding this feature would be equivalent to the initial import, and as the initial import it will be slow.

@BlackFoundry
Copy link
Member Author

I refer @justvanrossum note: "[git] should not be for backup, it should be the main data storage. mysql should be a speedy caching frontend that makes it better for users"
I am open to suggestions but I tend to agree with him here. We need to be able (if only for bug fixing) to act on the git repo as well, and that these changes are reflected in the frontend.

@justvanrossum
Copy link
Collaborator

I don't see how this should be as slow as an initial import: it only needs to read the files that have been changed.

I find it highly undesirable for the mysql frontend to be the only way to modify a project.

@fabiocaccamo
Copy link
Member

if you want to go fast it doesn't have to be the slowest (git) to lead :)

@justvanrossum
Copy link
Collaborator

The pull doesn't need to be instantaneous, it could be timed like the push. Although a force pull/push would be important to have, too.

@fabiocaccamo
Copy link
Member

fabiocaccamo commented Feb 15, 2021

But if it is not instantaneous, someone could do some changes in the meantime and this will generate conflicts.

@justvanrossum
Copy link
Collaborator

That is true, and that's a good reason for this to be an very exceptional case. Someone who is not mysql should manually ensure that it is safe to edit.

Maybe it is acceptable that if mysql detects a conflict, it simply commits the conflict with conflict markers and all, to be fixed manually.

Let me think. Perhaps there's a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants