Mention tips on GitHub doesn't work #1108

hawkeye116477 · 2019-08-23T14:56:42Z

When I want someone mention, then usually tips should be shown about who I want to mention. This works on Vivaldi and Firefox, but not on Waterfox 56. Can this be somehow fixed/implemented on Waterfox's side?
On console I have error TypeError: customElements.upgrade is not a function, it seems that disappears when I set dom.webcomponents.customelements.enabled to true, but mention tips still doesn't work.

The text was updated successfully, but these errors were encountered:

laniakea64 · 2019-08-23T15:14:34Z

Does it help to use a Firefox 60 user-agent for Github? -
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

hawkeye116477 · 2019-08-23T15:25:35Z

@laniakea64 No.

grahamperrin · 2019-08-23T15:59:04Z

Did this only recently stop working with Waterfox Classic?

hawkeye116477 · 2019-08-23T16:02:02Z

@grahamperrin No, as I remember this worked sometime ago on Waterfox, but I don't remember when it was.

Ibuprophen · 2019-08-23T17:47:38Z

I would like to confirm what @hawkeye116477 had reported regarding Waterfox Beta v56.1.0 (ARM).

I actually don't recall this ever working. My own workaround was to use the "Request Desktop Site" setting.

I just toggled the dom.webcomponents.customelements.enabled to true and it began working.

TBH... I just noticed this reported issue and was happy to get it working again using that suggestion... LOL! :-)

EDIT: I've been using the Mozilla/5.0 (Android 8.0.0; Mobile; rv:66.0.5) Gecko/66.0.5 Firefox/66.0.5agent for about a month or so that didn't affect this issue but, did improve my experience on many other websites (personally).

~Ibuprophen

hawkeye116477 · 2019-08-23T17:59:25Z

I should probably tell if it's on PC or smartphone, but that 56 version for Android isn't even on Google Play now, so I didn't take it into consideration. Anyway I talked about stable version for PC.

Ibuprophen · 2019-08-23T22:33:28Z

Yes, the Beta version is still available. I can see it in the Play Store as seen by the attached screenshot I had just made.

Screenshot_20190823-182844

~Ibuprophen

grahamperrin · 2019-08-23T23:49:04Z

see it in the Play Store

I, too, saw an installed version.

On my Android I had (2018-08-18) beta version 60.1.0 but as expected – #1085 – this morning after I uninstalled, I could not find any version to reinstall.

Mention tips

Maybe more than that, at least for users of Refined GitHub 19.1.31.1822. I have lost the ability to automatically preview the title of an issue (a tip) whilst writing. This feels like a very recent loss – like, within the past few days – so re: https://redd.it/ctttof I guess that it coincided with the reported end of support for legacy markup.

grahamperrin · 2019-08-24T00:47:02Z

With dom.webcomponents.customelements.enabled true I lose the ability to paste an image whilst writing.

Waterfox Classic 56.2.13 (20190822231313) on FreeBSD-CURRENT.

hawkeye116477 · 2019-08-24T08:03:39Z

With dom.webcomponents.customelements.enabled true I lose the ability to paste an image whilst writing.
I wrote previously that unfortunately doesn't help in that case, maybe on Android that have positive effect, but not on PC (Linux). Only error message disappears.

hawkeye116477 · 2019-09-06T12:47:38Z

Possibly related => https://bugzilla.mozilla.org/show_bug.cgi?id=1443722.
Appears that this is not implemented on Waterfox 56.2.14.

Ibuprophen · 2019-09-06T15:28:06Z

Just curious...

If changing the dom.webcomponents.customelements.enabled to true doesn't work out...

Does changing the dom.webcomponents.enabled to true have the same undesirable affect as well?

Thanks a Bunch! :-)

~Ibuprophen

hawkeye116477 · 2019-09-06T15:42:16Z

@Ibuprophen Yes, same negative effect.
As I wrote, this is rather job for @MrAlex94 to implement this 😄

Ibuprophen · 2019-09-06T16:12:43Z

I understand now... Thanks for the clarification! :-)

~Ibuprophen

IzzySoft · 2019-09-06T21:35:55Z

Just to mention: this did work for me until about 2 weeks ago. Stopped working around the time I updated to 56.2.13 – both on Linux and Windows (and stays broken with 56.2.14). Playing with the UA didn't fix it here either.

Another strange thing starting at the same time, but only on Linux: in the navigation bar on top, the "More" menu stayed open right from the time of loading the page. Fixing that one was rather easy via a userstyle. In case somebody else is affected:

@namespace url(http://www.w3.org/1999/xhtml);

@-moz-document domain("github.com") {
  .btn-link.reponav-item:hover + .dropdown-menu-content.js-menu-content, .dropdown-menu-content.js-menu-content:hover { display:block !important }
  .dropdown-menu-content.js-menu-content { display:none; }
}

grahamperrin · 2019-09-06T23:13:03Z

Thanks,

Another strange thing

Cross reference:

Waterfox Classic: Refined GitHub: More menu

IzzySoft · 2019-09-07T10:10:02Z

Uh, yes, that – and thanks for spreading the word 😄

Now we just need someone to come up with a userscript. Though I'm afraid that is not that easy. OTOH I wouldn't wonder if that could be done by comparing page source in WF with the same from a browser where it works. Wouldn't be the first time Github omits script entries based on browser, so maybe we'd just need to insert that back.

Anyone tried with a Chrome-based UA string, for example? Though I'm not sure what that might break then…

grahamperrin · 2019-09-07T14:43:25Z

need someone to come up with a userscript.

For @… completion, yes?

@github | cc @ACyphus re: #784 (comment) in November 2018, GitHub granted a UA-oriented whitelisting, for Waterfox to continue working normally. Thanks again for that.

Now – for this recent mentions issue – is another whitelisting possible/appropriate?

TIA for any advice

IzzySoft · 2019-09-07T18:14:30Z

For @… completion, yes?

Yes. That stopped working for me at about the time I updated to 56.2.13. Which includes the "tips".

And aren't those @… thingies called "mentions"? I thought we're talking about the very same thing: You start typing the "@", then usually a "tip" opens listing participants in the thread (plus the owner of the repo, if I got that correctly).

Thanks for the link – it seems that yes, another white-listing might be required (Github staff should be able to tell).

grahamperrin · 2019-09-07T18:41:26Z

aren't those @… thingies called "mentions"?

I do think so.

(I threw the phrase @… completion into the mix partly for search engine purposes, because other people might use words such as complete or autocomplete or auto-completion.)

grahamperrin · 2019-09-07T18:46:10Z

@hawkeye116477 re: your other comment yeah, I, too, have doubts.

(Re: polyfills, I saw your recent https://github.com/collinbarrett/FilterLists/issues/938 – thanks.)

hawkeye116477 · 2019-09-12T21:27:10Z

Seems that GitHub/Microsoft fixed this.

IzzySoft · 2019-09-13T06:56:40Z

Confirmed: It magically started working again yesterday. As for the "More" button, that was only half fixed: the drop-down now is completely hidden and doesn't open even on click. My UserStyle still fixes that.

grahamperrin · 2019-09-14T06:05:51Z

… lost the ability to automatically preview the title of an issue (a tip) whilst writing. …

This, too, appears to be fixed:

Thanks @github

… the "More" button, …

(Not a feature of GitHub.)

IzzySoft · 2019-09-14T16:06:18Z

Not? Then who places that there?

Looks like I'm using too many UserScripts and lost track then…

grahamperrin · 2019-09-14T22:59:25Z

#1108 (comment)

… Refined GitHub …

IzzySoft · 2019-09-14T23:30:32Z

Oh. Good guess I guess, I'm using that… Thanks! And uh, you've linked me that before and I didn't get that part, shame on me…

grahamperrin · 2019-09-15T15:45:59Z

NP :)

hawkeye116477 closed this as completed Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mention tips on GitHub doesn't work #1108

Mention tips on GitHub doesn't work #1108

hawkeye116477 commented Aug 23, 2019 •

edited

Loading

laniakea64 commented Aug 23, 2019

hawkeye116477 commented Aug 23, 2019

grahamperrin commented Aug 23, 2019

hawkeye116477 commented Aug 23, 2019 •

edited

Loading

Ibuprophen commented Aug 23, 2019 •

edited

Loading

hawkeye116477 commented Aug 23, 2019 •

edited

Loading

Ibuprophen commented Aug 23, 2019

grahamperrin commented Aug 23, 2019 •

edited

Loading

grahamperrin commented Aug 24, 2019

hawkeye116477 commented Aug 24, 2019 •

edited

Loading

hawkeye116477 commented Sep 6, 2019 •

edited

Loading

Ibuprophen commented Sep 6, 2019

hawkeye116477 commented Sep 6, 2019

Ibuprophen commented Sep 6, 2019

IzzySoft commented Sep 6, 2019

grahamperrin commented Sep 6, 2019

IzzySoft commented Sep 7, 2019

grahamperrin commented Sep 7, 2019

IzzySoft commented Sep 7, 2019

grahamperrin commented Sep 7, 2019

grahamperrin commented Sep 7, 2019

hawkeye116477 commented Sep 12, 2019

IzzySoft commented Sep 13, 2019 •

edited

Loading

grahamperrin commented Sep 14, 2019

IzzySoft commented Sep 14, 2019

grahamperrin commented Sep 14, 2019

IzzySoft commented Sep 14, 2019

grahamperrin commented Sep 15, 2019

Mention tips on GitHub doesn't work #1108

Mention tips on GitHub doesn't work #1108

Comments

hawkeye116477 commented Aug 23, 2019 • edited Loading

laniakea64 commented Aug 23, 2019

hawkeye116477 commented Aug 23, 2019

grahamperrin commented Aug 23, 2019

hawkeye116477 commented Aug 23, 2019 • edited Loading

Ibuprophen commented Aug 23, 2019 • edited Loading

hawkeye116477 commented Aug 23, 2019 • edited Loading

Ibuprophen commented Aug 23, 2019

grahamperrin commented Aug 23, 2019 • edited Loading

grahamperrin commented Aug 24, 2019

hawkeye116477 commented Aug 24, 2019 • edited Loading

hawkeye116477 commented Sep 6, 2019 • edited Loading

Ibuprophen commented Sep 6, 2019

hawkeye116477 commented Sep 6, 2019

Ibuprophen commented Sep 6, 2019

IzzySoft commented Sep 6, 2019

grahamperrin commented Sep 6, 2019

IzzySoft commented Sep 7, 2019

grahamperrin commented Sep 7, 2019

IzzySoft commented Sep 7, 2019

grahamperrin commented Sep 7, 2019

grahamperrin commented Sep 7, 2019

hawkeye116477 commented Sep 12, 2019

IzzySoft commented Sep 13, 2019 • edited Loading

grahamperrin commented Sep 14, 2019

IzzySoft commented Sep 14, 2019

grahamperrin commented Sep 14, 2019

IzzySoft commented Sep 14, 2019

grahamperrin commented Sep 15, 2019

hawkeye116477 commented Aug 23, 2019 •

edited

Loading

hawkeye116477 commented Aug 23, 2019 •

edited

Loading

Ibuprophen commented Aug 23, 2019 •

edited

Loading

hawkeye116477 commented Aug 23, 2019 •

edited

Loading

grahamperrin commented Aug 23, 2019 •

edited

Loading

hawkeye116477 commented Aug 24, 2019 •

edited

Loading

hawkeye116477 commented Sep 6, 2019 •

edited

Loading

IzzySoft commented Sep 13, 2019 •

edited

Loading