Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"waterfox --version" brands itself as "Mozilla Waterfox" #678

Closed
rehashedsalt opened this issue Jun 21, 2018 · 11 comments
Closed

"waterfox --version" brands itself as "Mozilla Waterfox" #678

rehashedsalt opened this issue Jun 21, 2018 · 11 comments

Comments

@rehashedsalt
Copy link

Describe the bug
Exactly what the title says. Waterfox, when invoked from the terminal with the --version or -v flags, prints its version information alongside the title "Mozilla Waterfox". As Waterfox is not associated with Mozilla, this is an error and a (non-serious) violation of their trademark.

Tested on Linux x86_64 56.2.1.

To Reproduce
Steps to reproduce the behavior:

  1. Open a terminal
  2. Invoke waterfox --version or waterfox -v

Expected behavior
The same, but without "Mozilla" prefixing it.

Screenshots
image

Desktop (please complete the following information):

  • OS: Debian x86_64
  • Version: Sid

Additional context
None necessary.

@grahamperrin
Copy link

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Jun 21, 2018

On application.ini also vendor is Mozilla 😄.

@rehashedsalt
Copy link
Author

@grahamperrin I could be mistaken, but that looks like it's only for using that particular logo and the "Powered by Mozilla" text, which appears in the footer of the project's website. Said footer also states:

Waterfox is NOT associated with Mozilla or its products.

And then the version information window tries to make it very clear that Waterfox isn't a Mozilla product:

image

All of this points toward the -v version string just being an oversight.

@grahamperrin
Copy link

grahamperrin commented Jun 26, 2018

… the -v version string just being an oversight.

👍 I guess so.

Plus https://www.reddit.com/comments/8sye18/-/e15i187/?context=1 clarity re: the footer. Association in terms of a company, so (for company number 08071145) we probably want Waterfox Ltd or WATERFOX LIMITED somewhere.

Plus this:

https://github.com/MrAlex94/Waterfox/blob/2bdc9aadfd5b57496450f9cb94b90376b7447e0e/browser/branding/unofficial/locales/en-US/brand.dtd#L9

I don't know the context in which that appears, but if the context does not make clear that it's about trademarks then (again) it's open to misinterpretation. https://trademarks.ipo.gov.uk/ipo-tmtext no match for Waterfox there but I don't want to complicate this issue.

Focusing …

Version string, branding

I can raise a pull request to address (at least) the version string, but for the version string alone, I'm not sure which files to target.

A brief comparison:

$ pkg info palemoon | grep Version
Version        : 27.9.3
$ palemoon --version
Moonchild Productions Pale Moon 27.9.3
$ uname
FreeBSD

https://github.com/MoonchildProductions/UXP/search?p=2&q=%22Moonchild+Productions%22&unscoped_q=%22Moonchild+Productions%22 in the UXP area helped me to identify some of what might change in the Waterfox area.

https://github.com/MoonchildProductions/UXP/blob/master/application/basilisk/branding/unofficial/locales/en-US/brand.properties#L9 there's a vendorFullName, https://github.com/MrAlex94/Waterfox/search?q=vendorFullName&unscoped_q=vendorFullName

couldn’t find any code matching 'vendorFullName' in MrAlex94/Waterfox


https://github.com/MrAlex94/Waterfox/blob/2bdc9aadfd5b57496450f9cb94b90376b7447e0e/browser/branding/unofficial/locales/en-US/brand.properties#L8

I wonder, if we add this below line 8:

vendorFullName=Waterfox Ltd

– will that cause Mozilla to not appear in the version string?

I did also glance at application.ini files, there are a few.

Postscript

Side note: it's New Moon on FreeBSD. tl;dr there's a bug.

@roman6626
Copy link

How is Waterfox unrelated to Mozilla?!! Waterfox is not an independent project. It works on the Mozilla code. And without Mozilla, he is not viable. It is just an assembly. This is not a fork!

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Dec 19, 2019

@roman6626
This is not a fork!
It's based on Firefox code and also has few own changes, so it's fork.

How is Waterfox unrelated to Mozilla?
It isn't associated with Mozilla, it's separate company, not owned by Mozilla.

Please don't shout!

@roman6626
Copy link

roman6626 commented Dec 19, 2019

I don't scream at all. I speak very quietly. Just call a spade a spade.
There are a large number of browsers based on the Mozilla source code, but only the Pale Moon (now the Basilisk) makes a complete fork of the Gecko engine. Both the first and second did a branch from the original code base at the time of monumental changes in the architecture of the declared Mozilla. Everything else is an assembly based on a fixed engine. A fork of Quantum will only happen when the current Servo begins to radically change the internal architecture and the license for the outdated kernel changes. Until then there will be repacks, assemblies, recompilations, rebuilds, etc. names of the same class of products based on an unchanged code base, differing only in a set of truncated technologies, optimizations at the level of configs.
Many assemblies also have Chrome. As far as I know, none of their creators makes a fork of Blink, but uses the experience of the Chromium project unchanged. The difference between these browsers is only in the installed add-ons and tweaks produced by the author.

@roman6626
Copy link

roman6626 commented Dec 19, 2019

By the way, you yourself advised using the Moonchild products. Because they are less dependent on the parent, unlinked from the Mozilla code. They receive not only security patches, but also develop independently. :-)

@rehashedsalt
Copy link
Author

Mozilla does not publish Waterfox. Waterfox explicitly states that it is "not associated with Mozilla". Per the MPL, which Firefox is licensed under, Waterfox is not permitted to use the name "Mozilla" to brand its browser.

Call it whatever you want -- fork, assembly, reskin, or otherwise -- but it runs afoul of license terms to call it "Mozilla Waterfox".

@roman6626
Copy link

roman6626 commented Dec 20, 2019

I agree. Different names. Let it be called whatever you like.
I talked about something else. There is a big difference between the concepts of fork and assembly. That's all. :-)
The Сhromium has no fork! We do not consider Сhrome. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants