Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Built-in device model can be removed #2856

Open
adcoly opened this issue Feb 6, 2024 · 0 comments
Open

Bug: Built-in device model can be removed #2856

adcoly opened this issue Feb 6, 2024 · 0 comments
Assignees
@judramos
Labels
bug Something isn't working
Milestone
v6.0

Comments

@adcoly
Copy link

adcoly commented Feb 6, 2024

Expected Behavior

When I create a device model via the API with built-in parameter equal true, I should have a device model that can't be removed through the portal web interface.

Current Behavior

At the moment, the device can't be removed from the model list view.
image

But if we go to the model detail, the 'delete' button is available and working.
image
image

Steps to Reproduce

  • Create a device model from the API with 'builtIn = true'
  • Connect to the portal.
  • Head to the detail page of the newly created model.
  • Click on the 'Delete' button

Context (Environment)

Portal version: 4.13.2
LoRaWAN Stack version: 2.2.0
@adcoly adcoly added the bug Something isn't working label Feb 6, 2024
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Feb 6, 2024
@Metal-Mighty Metal-Mighty added this to the v6.0 milestone May 24, 2024
@judramos judramos mentioned this issue Oct 14, 2024
Open
@judramos judramos self-assigned this Oct 14, 2024
@judramos judramos moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Oct 14, 2024
@judramos judramos moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal Oct 31, 2024
@judramos judramos linked a pull request Nov 29, 2024 that will close this issue
Scheduler and plannings management #3247
Closed
9 tasks
kbeaugrand added a commit that referenced this issue Dec 5, 2024
@kbeaugrand @judramos
Scheduler and plannings management (#3255)
0cd18a2 
* Add of layerId in device twin

* #2998 Quartz migration for SendPlanningCommand

* #2856 Disable built-in device model deletion

* #3238 Update view when a device is unchecked

* 3239 Allow to delete a planning from client

* 3239 Allow to delete a planning

* 2998 Schedule commands

* #3239 Change checkboxes for layers displayed

* Merge from main

* 2516 add supportLoRaFeatures tag in template file

* #3250 Import device list using the template given

* #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models

* #3251 Import device - data overwritten

* Unit tests

* Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>

* #2958 Remove 'Connection State' and 'Last status update' columns

* #3023 startupOrder not supported in Edge Device Model schema

---------

Co-authored-by: E068097 <[email protected]>
Co-authored-by: judramos <[email protected]>
@kbeaugrand kbeaugrand mentioned this issue Dec 5, 2024
Draft
9 tasks
kbeaugrand added a commit that referenced this issue Dec 5, 2024
@kbeaugrand @judramos
Scheduler and plannings management (#3255)
d6f81cc 
* Add of layerId in device twin

* #2998 Quartz migration for SendPlanningCommand

* #2856 Disable built-in device model deletion

* #3238 Update view when a device is unchecked

* 3239 Allow to delete a planning from client

* 3239 Allow to delete a planning

* 2998 Schedule commands

* #3239 Change checkboxes for layers displayed

* Merge from main

* 2516 add supportLoRaFeatures tag in template file

* #3250 Import device list using the template given

* #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models

* #3251 Import device - data overwritten

* Unit tests

* Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>

* #2958 Remove 'Connection State' and 'Last status update' columns

* #3023 startupOrder not supported in Edge Device Model schema

---------

Co-authored-by: E068097 <[email protected]>
Co-authored-by: judramos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judramos judramos

Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 💬 Ready for Review
Milestone
v6.0
Development

Successfully merging a pull request may close this issue.

Scheduler and plannings management judramos/IoT-Hub-Portal
3 participants
@Metal-Mighty @adcoly @judramos