Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braavos wallet write returns an error for successful executions #70

Open
tomashobza opened this issue May 1, 2024 · 8 comments
Open
Assignees

Comments

@tomashobza
Copy link
Contributor

image

  • in files frontend/src/components/NewProposalForm.tsx & frontend/src/components/Proposal.tsx
  • Braavos wallet connection only works on HTTPS or localhost
  • transaction goes through but an error is returned by the SDK
@tensojka
Copy link
Contributor

tensojka commented May 1, 2024

@DaveVodrazka I assume you faced this issue already, not really a blocker since the tx still goes through, but curious to know what's wrong

@DaveVodrazka
Copy link
Contributor

I don't use starknet-react on the Carmine app, so I don't have much experience with it 🤷‍♂️
But if I have the time I will check what's going on (but probably not anytime soon)

@Jemiiah
Copy link

Jemiiah commented Aug 12, 2024

I would love to work on this Issue @tensojka

@tensojka
Copy link
Contributor

@Jemiiah were you able to reproduce it?

@Jemiiah
Copy link

Jemiiah commented Aug 13, 2024

Yes I was @tensojka and I’ll be able to fix it by 2 days

@tensojka
Copy link
Contributor

great, go ahead then

@tensojka tensojka assigned Jemiiah and unassigned DaveVodrazka Aug 13, 2024
Copy link

onlydustapp bot commented Aug 13, 2024

Hey @tensojka!
Thanks for showing interest.
We've created an application for you to contribute to Konoha.
Go check it out on OnlyDust!

@Jemiiah
Copy link

Jemiiah commented Aug 13, 2024

Great!!! @tensojka thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants