Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: simpler example #83

Open
jkitchin opened this issue Oct 8, 2024 · 5 comments
Open

[Feature Request]: simpler example #83

jkitchin opened this issue Oct 8, 2024 · 5 comments
Assignees

Comments

@jkitchin
Copy link
Contributor

jkitchin commented Oct 8, 2024

Feature Requested

It would be helpful to have an example alabos that people can use out of the box. I am trying to make one myself with https://claude-light.cheme.cmu.edu/api. This is a remote device with a REST API. It seems like it should be easy to make a Device that uses requests to make a measurement, and some Tasks for different kinds of measurements. There isn't a concept of a sample for the device, you just set RGB levels, and measure intensities out.

Proposed Solution

I am pretty close to a solution, and would be happy to make a pull request when it is working.

Relevant Information

No response

@idocx
Copy link
Member

idocx commented Oct 8, 2024

Agree! I will work on a simpler example this week. I plan to put it in the default project so that users can have a runnable code after executing alaos init.

@idocx idocx self-assigned this Oct 8, 2024
@idocx
Copy link
Member

idocx commented Oct 8, 2024

For the sample concept, alabos itself supports the execution of experiments without samples. But you may not be able to directly use the experiment submission script mentioned in the document: https://cedergrouphub.github.io/alabos/submit_experiments.html.

I can also add an example to the example folder to show how we can do that.

@jkitchin
Copy link
Contributor Author

jkitchin commented Oct 8, 2024

I have a working example alab that should work out of the box at https://github.com/jkitchin/alabos/tree/main/examples/claude-light.

It uses an instrument I created at http://claude-light.cheme.cmu.edu

I would be happy to get feedback on it. If you are interested, I could make a pull request.

@idocx
Copy link
Member

idocx commented Oct 8, 2024

I have a working example alab that should work out of the box at https://github.com/jkitchin/alabos/tree/main/examples/claude-light.

It uses an instrument I created at http://claude-light.cheme.cmu.edu

I would be happy to get feedback on it. If you are interested, I could make a pull request.

Hi John! This is really amazing! I tried your code on my laptop. It worked perfectly. I checked the code. It is exactly how we expected users to program with AlabOS.

I am very interested in adding this example to the alabos example folder as it is. If you have time, could you create a pull request? Thank you very much!

@jkitchin
Copy link
Contributor Author

jkitchin commented Oct 9, 2024

I submitted a pull request at #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants