Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support withXml ConfigOption #256

Open
Chrimle opened this issue Dec 14, 2024 · 1 comment
Open

Support withXml ConfigOption #256

Chrimle opened this issue Dec 14, 2024 · 1 comment
Assignees
@Chrimle
Labels
feat Feature change MINOR Backwards-compatible new feature
Milestone
Support all defau...

Comments

@Chrimle
Copy link
Owner

Chrimle commented Dec 14, 2024 •
edited
Loading

  • Annotate generated record with @XmlRootElement and @XmlAccessorType(XmlAccessType.FIELD).
  • Annotate each generated field with @XmlElement
    • Preferably with the name set to the name of the field (to be consistent with openapi-generator-maven-plugin)
@Chrimle Chrimle self-assigned this Dec 14, 2024
@Chrimle Chrimle converted this from a draft issue Dec 14, 2024
@Chrimle Chrimle moved this from Backlog to Analyze in openapi-to-java-records-mustache-templates Dec 14, 2024
@Chrimle Chrimle added feat Feature change MINOR Backwards-compatible new feature labels Dec 14, 2024
@Chrimle Chrimle changed the title Investigate withXml configuration option Support withXml ConfigOption Dec 15, 2024
@Chrimle
Copy link
Owner Author

Chrimle commented Dec 15, 2024

Appears to not be supported without further considerations - especially during deserialization, see Java records: Serialization, marshaling, and bean state validation.

Furthermore, looking at Jakarta EE's JAXB API, this is not supported yet: jakartaee/jaxb-api#183.

However, it wouldn't be much effort to add these annotations. But it may cause confusion if it is technically only partially supported (if at all). A disclaimer can be put in the PR/Release, and on the wiki. But until then, this will be marked as Blocked.

@Chrimle Chrimle moved this from Analyze to Blocked in openapi-to-java-records-mustache-templates Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chrimle Chrimle

Labels
feat Feature change MINOR Backwards-compatible new feature
Projects
openapi-to-java-records-mustache-templates
Status: Blocked
Milestone
Support all default `<configOptions>`...
Development

No branches or pull requests
1 participant
@Chrimle