Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework full screen layout #167

Open
inghamn opened this issue May 7, 2018 · 1 comment
Open

Rework full screen layout #167

inghamn opened this issue May 7, 2018 · 1 comment
Labels
UI User Interface change

Comments

@inghamn
Copy link
Member

inghamn commented May 7, 2018

The current implementation is very rigid. We cannot add new elements or increase the amount of text without having to redo many hard coded CSS size declarations. If we want to stick with a full-screen layout, we should switch to declaring the layout in vh units.

https://developer.mozilla.org/en-US/docs/Web/CSS/length
@inghamn inghamn modified the milestone: 1.2 May 7, 2018
@inghamn inghamn added the UI User Interface change label May 7, 2018
@inghamn inghamn changed the title Rework full screen layout into VH units Rework full screen layout May 7, 2018
@inghamn
Copy link
Member Author

inghamn commented May 7, 2018

Actually, we might want to do a layout using flexbox. It's supported by all browsers nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI User Interface change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inghamn