Is it important that we skip the first time-step?

[glwagner]

I had a minor concern that the newest change to run! added a little bit of indirection that inhibits interpretability. We can slightly simplify the algorithm (IMO) if we don't need to skip the first time-step here:

Oceananigans.jl/src/Simulations/run.jl

Line 134 in 0b6e88e

time_step_or_skip!(sim)

@tomchor can you advise?

[tomchor]

I think it's very unlikely that the first step needs to be skipped, since I think we decided the source of these errors was the rounding up after many operations, no? So we could try removing that part of the code and I guess time will tell if this produces issues.

That said, I also don't see a problem with skipping the first iteration. Are you reluctant because there might be issues with a first iteration skip, or is it just a matter of simplifying the loop?

[glwagner]

just makes the code easier to understand

[tomchor]

If you wanna make that change, I'm okay with it.

[glwagner]

ok thank you!