Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static typing issues for: tests.plotting_tests #477

Open
kevinsantana11 opened this issue Jun 19, 2024 · 3 comments
Open

Fix static typing issues for: tests.plotting_tests #477

kevinsantana11 opened this issue Jun 19, 2024 · 3 comments

Comments

@kevinsantana11
Copy link
Contributor

No description provided.

@kevinsantana11 kevinsantana11 converted this from a draft issue Jun 19, 2024
@philippemiron
Copy link
Contributor

philippemiron commented Aug 2, 2024

@kevinsantana11, could you help me understand what is the current issue and what do we have to do to for those static typing issues?

@kevinsantana11
Copy link
Contributor Author

Hi @philippemiron, I should have added more detail here but this is about running mypy and fixing the typing issues it prints out for the file associated with the issue.

We may be missing typing around functions, there may be places where we're not check for None or the functions defines specific argument types and we're passing something that doesn't match.

Let me know if that helps. I can run mypy and attach the out put we want to fix tomorrow

@philippemiron
Copy link
Contributor

I'll try it out and let you know. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants