Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't know how to request changes so here goes. Basically, there is a line of code that changes one of the rotors when you type #11

Open
jso8910 opened this issue Jul 23, 2020 · 3 comments

Comments

@jso8910
Copy link

jso8910 commented Jul 23, 2020

Ok, here it is:

    if (currentNo == inputNo) {
      println(inputNo, rotor1.position, rotor2.position, rotor3.position);
    }
    // This line below
    moveRotors();

    return letterOrderLowerCase.charAt(currentNo);
  }

This is line 57 in the Enigma class. For anyone wondering, the solution is to remove it (though I recommend commenting it out), but I would appreciate if someone removed it from the master branch. Anyways, that is the issue with the solution.

@MarnusStoop
Copy link

The engima did advance the right most rotor with each keypress, and after a certain amount of presses it would advance the next rotor by one and so one. So the rotors being advanced is correct

@jso8910
Copy link
Author

jso8910 commented Jul 24, 2020

The engima did advance the right most rotor with each keypress, and after a certain amount of presses it would advance the next rotor by one and so one. So the rotors being advanced is correct

I did not know that! I had some notion that you wrote down the message, and just put it back in and the correct ones will light up. Do you also (somehow) write the starting position of the right one?

@utdrmac
Copy link

utdrmac commented Nov 3, 2020

@jso8910 Can you close this out since it's not an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants