Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Explicit virtual environment management in ComfyInstallation class #715

Open
huchenlei opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@huchenlei
Copy link
Member

huchenlei commented Jan 24, 2025

Currently virtual environment is recreated everytime basePath is updated implicitly.

_basePath: string;
/** The base path of the desktop app. Models, nodes, and configuration are saved here by default. */
get basePath() {
return this._basePath;
}
set basePath(value: string) {
// Duplicated in constructor to avoid non-nullable type assertions.
this._basePath = value;
this.virtualEnvironment = this.createVirtualEnvironment(value);
}

We should make this more explicit, i.e. move the side effect in the setter to the callsites.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei added the enhancement New feature or request label Jan 24, 2025
@webfiltered
Copy link
Contributor

Thought I already had an issue for this, but apparently not - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants