Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with third party apps: Further integration with FAO-WOCAT.  #824

Open
amyburness opened this issue Jul 4, 2024 · 8 comments · May be fixed by #855
Open

Integration with third party apps: Further integration with FAO-WOCAT.  #824

amyburness opened this issue Jul 4, 2024 · 8 comments · May be fixed by #855
Assignees
Labels

Comments

@amyburness
Copy link
Collaborator

Further integration with FAO-WOCAT. 

@amyburness
Copy link
Collaborator Author

amyburness commented Jul 4, 2024

Deliverables for Integration tasks:

  • Adapted GUI for FAO-WOCAT.

@Samweli Samweli added the size: 20 I’m sorry it will take at least two to three days. label Jul 19, 2024
@amyburness amyburness added this to the Kartoza Support 2024 milestone Sep 15, 2024
@amyburness amyburness reopened this Sep 18, 2024
@amyburness amyburness reopened this Nov 18, 2024
@amyburness
Copy link
Collaborator Author

amyburness commented Nov 22, 2024

for FAO-WOCAT we want to allow the user to use the advanced settings for fao - wocat
chat to Cesar Garcia on the code

@amyburness
Copy link
Collaborator Author

amyburness commented Nov 26, 2024

UI Updates:

  • Add FAO-WOCAT radio box
    Image

  • When the radio box is chosen then the user should be able to access the same settings and advanced settings as that used for the Trends Land use data
    Image

The FAO-WOCAT data interface needs to be available for the all indicators option and the land productivity option
Image

We have the GEE code for the FAO-WOCAT data and need to meet with Cesar to check if the advanced setting parameters are correct for the analysis.

@Samweli Samweli linked a pull request Nov 27, 2024 that will close this issue
@amyburness
Copy link
Collaborator Author

amyburness commented Dec 18, 2024

For FAO-WOcat the period is important to define in the beginning.
image

Code : https://code.earthengine.google.com/0fe1c192e5137151df30a0d2ff7f6039
can we move the period choice options to above the NDVI options.
image

image

remove the start and end and replace them with just one box to add a period -> only for the FAO advanced options.

image
image
remove the climate option to keep FAO-WOCAT
image
performance should be replaced with Initial Biomass
image
only allow users to edit low and high boxes and the mid value is shown but not editable.

@amyburness
Copy link
Collaborator Author

amyburness commented Dec 20, 2024

We need to make the remote server processing work based on the Code here:
https://code.earthengine.google.com/0fe1c192e5137151df30a0d2ff7f6039
in the conservation international GH
@azvoleff needs to give @Samweli access. it may be useful to add Danang or Dimas.

@mvmaltitz mvmaltitz added Feedback Pending and removed size: 20 I’m sorry it will take at least two to three days. labels Jan 8, 2025
@azvoleff
Copy link
Contributor

@Samweli I've given you admin access to the trends.earth API server, which is needed to deploy this feature (following the process outlined here).

In addition to the GUI changes gee/sdg-15-3-1-sub-indicators/src/main.py will need to be modified to correctly handle the new FAO-WOCAT parameterization, as will gee/productivity/src/main.py for the case of users running just the productivity dataset but not the full SDG.

New code for actually running the calculations (the code running the algorithm itself as opposed to just calling our API) should go somewhere in te_algorithms/gee (perhaps in te_algorithms/gee/productivity.py - but that script is getting a bit long and likely needs to be split up).

As a side note, the code in trends.earth-algorithms cannot depend on QGIS. We intentionally keep code that relies on QGIS within the trends.earth repo as the code in trends.earth-algorithms is run on headless servers for testing and automated production of the default data for UNCCD.

@Samweli
Copy link
Collaborator

Samweli commented Jan 22, 2025

Thanks

@Samweli I've given you admin access to the trends.earth API server, which is needed to deploy this feature (following the process outlined here).

In addition to the GUI changes gee/sdg-15-3-1-sub-indicators/src/main.py will need to be modified to correctly handle the new FAO-WOCAT parameterization, as will gee/productivity/src/main.py for the case of users running just the productivity dataset but not the full SDG.

New code for actually running the calculations (the code running the algorithm itself as opposed to just calling our API) should go somewhere in te_algorithms/gee (perhaps in te_algorithms/gee/productivity.py - but that script is getting a bit long and likely needs to be split up).

As a side note, the code in trends.earth-algorithms cannot depend on QGIS. We intentionally keep code that relies on QGIS within the trends.earth repo as the code in trends.earth-algorithms is run on headless servers for testing and automated production of the default data for UNCCD.

Thanks @azvoleff, I will create new issues for each of these action items and work on them.

@Samweli
Copy link
Collaborator

Samweli commented Jan 22, 2025

In addition to the GUI changes gee/sdg-15-3-1-sub-indicators/src/main.py will need to be modified to correctly handle the new FAO-WOCAT parameterization, as will gee/productivity/src/main.py for the case of users running just the productivity dataset but not the full SDG.

@azvoleff from the chat with Cesar he mentioned that the new FAO-WOCAT should be only available remotely, doesn't modifying these gee scripts make it also available locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants