Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrast-sdk-python tests incorrectly pass when given bad login data #12

Open
pardeema-contrast opened this issue Aug 18, 2021 · 0 comments

Comments

@pardeema-contrast
Copy link

Because the tests appear to be checking for a 200 response code from the server, they will pass even if data is bad in test-config.json

I think this is because the Python requests library automatically does redirects and a bad Contrast request redirects back to login.

For example, I set a bogus username, api_key, and server_key and all tests in the test suite pass, but never will actually return any meaningful data.

Issue could be resolved by setting all Python requests calls use allow_redirects=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant