Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error checking before creation and deletion #121

Open
1 task done
AnushK-Fro opened this issue Nov 10, 2024 · 1 comment
Open
1 task done

Add error checking before creation and deletion #121

AnushK-Fro opened this issue Nov 10, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@AnushK-Fro
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

The current approach in Convoy fires off a job to create and delete a virtual machine. This has the advantage of speeding up the creation and deletion process. However, if a deployment fails, then it is not possible for an application such as WHMCS or Blesta to find out about it unless they are polling Convoy and constantly checking the status. For example, if a host node is down and Convoy tries deploying a VM on it, that VM will be fail to install but WHMCS would mark it as provisioned since Convoy returns no error through the API.

Describe the solution you'd like.

Convoy should run tests to make sure that the virtual machine can deploy before deploying the machine. If it detects that it cannot deploy a virtual machine for some reason (i.e., node is offline, template is not on the destination node, etc), then it should not. It may not even be necessary to fire off the creation or deletion process as a job.

Additional context to this request.

No response

@AnushK-Fro AnushK-Fro added the enhancement New feature or request label Nov 10, 2024
@ericwang401

This comment was marked as resolved.

@ericwang401 ericwang401 added the question Further information is requested label Nov 10, 2024
@ericwang401 ericwang401 removed the question Further information is requested label Nov 18, 2024
@ericwang401 ericwang401 added this to the vX milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants