Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SA] Consider using dr_flac instead of libflac. #146

Open
MikuAuahDark opened this issue Jan 2, 2025 · 1 comment · May be fixed by #149
Open

[SA] Consider using dr_flac instead of libflac. #146

MikuAuahDark opened this issue Jan 2, 2025 · 1 comment · May be fixed by #149
Labels
gta sa Issue concerns GTA San Andreas

Comments

@MikuAuahDark
Copy link

MikuAuahDark commented Jan 2, 2025 •
edited
Loading

... but why? There are 2 reasons:

  • dr_flac is single file, lessen the friction to build SA for GTASA compared when using libflac.
  • dr_flac is slightly easier to use.

I've been using dr_flac for FLAC integration in a game framework and it's quite easy to use and does its job very well.

If patches are welcome, I may able to create a PR for this in the far future once I got the necessary libraries setup in my machine.
@CookiePLMonster CookiePLMonster added the gta sa Issue concerns GTA San Andreas label Jan 2, 2025
@CookiePLMonster
Copy link
Owner

If patches are welcome, I may able to create a PR for this in the far future once I got the necessary libraries setup in my machine.

This would be nice! The current implementation is from 2014 and it likely predates dr_flac, but I heard about it in the past and we've used it elsewhere.

@CookiePLMonster CookiePLMonster linked a pull request Jan 14, 2025 that will close this issue
Replace libflac with dr_flac #149
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gta sa Issue concerns GTA San Andreas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace libflac with dr_flac vintnarni/SilentPatch
2 participants
@MikuAuahDark @CookiePLMonster