Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ScriptStore/ScriptExecute API to conform with RedisAI changes #242

Open
3 tasks
billschereriii opened this issue Mar 28, 2022 · 0 comments
Open
3 tasks

Update ScriptStore/ScriptExecute API to conform with RedisAI changes #242

billschereriii opened this issue Mar 28, 2022 · 0 comments
Labels
API break Issues that include incompatible API changes area: C++ Issues related to the C++ client area: C Issues related to the C client area: fortran issues related to the Fortran Client area: python Issues related to the Python Client

Comments

@billschereriii
Copy link
Contributor

billschereriii commented Mar 28, 2022 •
edited
Loading

Description

RedisAI has deprecated the AI.SCRIPTSET and AI.SCRIPTRUN API functions and added some additional functionality to the replacement AI.SCRIPTSTORE and AI.SCRIPTEXECUTE functions. The SmartRedis API should be updated to conform with these changes.

Justification

The additional features of the API are useful for users, and the existing RedisAI API will be removed in future releases.

Implementation Strategy

The following changes are needed:

  • ScriptSet changed to ScriptStore. ScriptStore has an additional parameter ENTRY_POINTS which will need to be added to the SmartRedis API.
  • Update unit tests to comply with the new script API
  • Update examples to comply with the new script API
@billschereriii billschereriii added the type: feature Issues that include feature request or feature idea label Mar 28, 2022
@mellis13 mellis13 added the API break Issues that include incompatible API changes label Apr 15, 2022
@mellis13 mellis13 changed the title Update ScriptSTore/ScriptExecute API to conform with RedisAI changes Update ScriptStore/ScriptExecute API to conform with RedisAI changes Feb 23, 2023
@mellis13 mellis13 added area: python Issues related to the Python Client area: C++ Issues related to the C++ client area: C Issues related to the C client area: fortran issues related to the Fortran Client and removed type: feature Issues that include feature request or feature idea labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API break Issues that include incompatible API changes area: C++ Issues related to the C++ client area: C Issues related to the C client area: fortran issues related to the Fortran Client area: python Issues related to the Python Client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mellis13 @billschereriii