Third-party software is installed to SmartRedis install directory #344
Labels
area: build
Issues related to builds, makefiles, installs, etc
area: C++
Issues related to the C++ client
area: examples
Issues related to tutorials and examples
area: test
Issues related to the test suite
area: third-party
Issues related to depencies and third-party package integrations
bug: major
A major bug
type: usability
Issues related to ease of use
Description
Third-party software is added to the SmartRedis
install/lib
andinstall/include
directories. This pollutes our installation and complicates clean up make targets includeclean
andclobber
.How to reproduce
After building the library, inspect the resulting install folder.
Expected behavior
Third-party software should remain contained to the
third-party/
folder.Insufficient fix
An initial attempt to correct this problem consisted of:
SR_ROOT/third-party/install
While these steps are definitely needed in any solution, they are insufficient at present because several of our source files include headers that themselves include third-party dependencies,
sw/redis++.h
being the most common of these. With no other changes, this would add a requirement on our C++ users that they have to include a-I $(SMARTREDIS_ROOT)/third-party/install
flag to their compile and link steps that they should not have to do.The need to add an include directory would break our users' software builds. An additional step is needed to keep this from happening:
The text was updated successfully, but these errors were encountered: