Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD tests produce deprecation warnings #361

Open
billschereriii opened this issue Jun 27, 2023 · 4 comments
Open

CI/CD tests produce deprecation warnings #361

billschereriii opened this issue Jun 27, 2023 · 4 comments
Labels
area: python Issues related to the Python Client area: test Issues related to the test suite bug: minor A minor bug

Comments

@billschereriii
Copy link
Contributor

Description

Running our unit tests on CI/CD produces deprecation warnings

How to reproduce

Run tests on CI/CD and observe the output. You should find something similar to the following:

  /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/pytest_cov/plugin.py:233: PytestDeprecationWarning: The hookimpl CovPlugin.pytest_configure_node uses old-style configuration options (marks or attributes).
  Please use the pytest.hookimpl(optionalhook=True) decorator instead
   to configure the hooks.
   See https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers
    def pytest_configure_node(self, node):

../../../../../opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/pytest_cov/plugin.py:242
  /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/pytest_cov/plugin.py:242: PytestDeprecationWarning: The hookimpl CovPlugin.pytest_testnodedown uses old-style configuration options (marks or attributes).
  Please use the pytest.hookimpl(optionalhook=True) decorator instead
   to configure the hooks.
   See https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers
    def pytest_testnodedown(self, node, error):

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Expected behavior

Running tests shouldn't produce deprecation warnings. Test code should be tweaked to not generate these warnings

@billschereriii billschereriii added area: test Issues related to the test suite area: python Issues related to the Python Client bug: minor A minor bug labels Jun 27, 2023
@billschereriii
Copy link
Contributor Author

This appears to be specific to the code coverage package we're using and not part of the SmartRedis code itself

@mellis13
Copy link
Collaborator

@billschereriii Let's update / change this to do an investigation of dependency update.

@billschereriii
Copy link
Contributor Author

The warning is coming when you run Python tests, but is generated against ../../../../../opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/pytest_cov/plugin.py which is not source code that is under our control.

@billschereriii
Copy link
Contributor Author

The warning appears as part of the PyTest summary after completing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python Issues related to the Python Client area: test Issues related to the test suite bug: minor A minor bug
Projects
None yet
Development

No branches or pull requests

2 participants