Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No extension URL issues in 0.6.1 ? #186

Open
tehmaestro opened this issue Jul 29, 2015 · 1 comment
Open

No extension URL issues in 0.6.1 ? #186

tehmaestro opened this issue Jul 29, 2015 · 1 comment

Comments

@tehmaestro
Copy link

Hey. I think there's a problem with supporting no extension URLs in 0.6.1

The method s.createInstance, is only parsing the src with var details = s._parsePath(src.src); , which will fail for src's which have no extension. I think we need to use the parseSrc function, so that the src is validated, but there is a catch.

Calling src = s._getSrcById(src); a few lines up, only returns the src, without the extension, so parseSrc would always fail.

I don't know if I make any sense, but is there an example for using extension-less URLs?
Thank you.

@tehmaestro tehmaestro changed the title No extension problems? No extension problems in 0.6.1 ? Jul 29, 2015
@tehmaestro tehmaestro changed the title No extension problems in 0.6.1 ? No extension URL issues in 0.6.1 ? Jul 29, 2015
@wdamien
Copy link
Member

wdamien commented Jul 30, 2015

Yes, this is a known issue. Its basically a duplicate of #120, since the fix will be the same for blob urls, and other urls without extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants