Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing setuptools dependency #64

Closed
wants to merge 1 commit into from
Closed

Fix missing setuptools dependency #64

wants to merge 1 commit into from

Conversation

FlotterCodername
Copy link

Fixes #63

@parona-source
Copy link

Alternatively importlib.metadata could be used, its not available in the now EOL python3.7 but it does have a backport.

pkg_resources is discouraged either way by setuptools https://setuptools.pypa.io/en/latest/pkg_resources.html.

The use here is very minimal and can be changed like I did here nicolasbock/ebuildtester@e95c342

Only minus is python 3.7 requiring a backport, but python3.7 should be dropped from the CI by now already...

@oscargus
Copy link

oscargus commented Jun 1, 2024

pkg_resources is dropped in setuptools 70, so it should either be pinned to <70 or, better, use importlib.

@FlotterCodername
Copy link
Author

pkg_resources is dropped in setuptools 70, so it should either be pinned to <70 or, better, use importlib.

Thanks for the headsup! In this case I'm going to close the PR.
I think pinning a package like setuptools is not acceptable. With no response from maintainers in half a year it appears hopeless to get a merge for the correct approach.
I've migrated everything to MyST already anyway. The success of MyST is probably also a reason why this package now appears abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undeclared setuptools dependency
3 participants