Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return record should encode with latin #33

Open
thanatoskira opened this issue Apr 22, 2020 · 2 comments
Open

return record should encode with latin #33

thanatoskira opened this issue Apr 22, 2020 · 2 comments

Comments

@thanatoskira
Copy link

shoud encode return record with 'latin', eg:'220'.encode() will get '\xc3\x9c'

class A(DNSResponse):
    def __init__(self, query, record):
        super(A, self).__init__(query)
        self.type = b"\x00\x01"
        self.length = b"\x00\x04"
        self.data = self.get_ip(record).encode('latin')  <----
@Crypt0s
Copy link
Owner

Crypt0s commented Apr 22, 2020

whups, thanks for catching that. I'll fix that shortly...

@FredL69
Copy link

FredL69 commented May 7, 2020

The real fix is this PR #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants