Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm is not defined.. #1

Open
et opened this issue Sep 9, 2016 · 11 comments
Open

Elm is not defined.. #1

et opened this issue Sep 9, 2016 · 11 comments

Comments

@et
Copy link

et commented Sep 9, 2016

Hey this is similar to #9 except I'm on a mac.
I noticed that I was getting the following error:

09 Sep 13:51:28 - info: compiling
Elm compile: SeatSaver.elm, in web/elm, to ../static/vendor/seatsaver.js
/bin/sh: node_modules/elm/binwrappers/elm-make: No such file or directory
09 Sep 13:51:30 - error: Compiling of web/elm/SeatSaver.elm failed. Command failed: node_modules/elm/binwrappers/elm-make --yes --output ../static/vendor/seatsaver.js SeatSaver.elm
/bin/sh: node_modules/elm/binwrappers/elm-make: No such file or directory
 ^G
09 Sep 13:51:30 - info: compiled 6 files into 2 files, copied 3 in 12 sec

This was due to the line executablePath in the brunch-config.json.

I changed this:

executablePath: './node_modules/elm/binwrappers'

to

executablePath: '../../node_modules/elm/binwrappers',

and everything was 👌

@urfolomeus
Copy link
Contributor

Hi @et, thanks for raising an apologies for the slow reply. This is down to the fact that elm-brunch now enables you to specify where your Elm executable lives, which is a great feature. I'll update the notes over the next few days to point this out and give you credit for the mention.

@et
Copy link
Author

et commented Sep 12, 2016

Cheers for the great tutorial @urfolomeus 🍻
I'm half way through the blog posts and have learned so much from them. Thank you kindly for your contributions.

@urfolomeus
Copy link
Contributor

You're welcome. Happy to share 😊

Incidentally, I've only updated up to post #6 with the latest Elm, so you might hit issues after that. Hoping to have time to get some more updated soon.

@et
Copy link
Author

et commented Sep 12, 2016

No problem. I'm intending to get through the rest of the blog posts this week so I'll raise issues for anything that doesn't work with the latest Elm 😄

@urfolomeus
Copy link
Contributor

That would be very much appreciated! 😁

@zwhitchcox
Copy link

Please update this soon! Just spent >2h looking for this bug!

@urfolomeus
Copy link
Contributor

@zwhitchcox sorry you're feeling frustrated. I've been off work for a while with ill health. I'm not sure when I'll have time to get back to this.

@urfolomeus
Copy link
Contributor

@et @zwhitchcox decided to just fix this here for now. Will update the associated blog posts at the start of the week. @et your attribution will be in the updated blog post (probably just 2 I think?)

Apologies again for the delay in getting this fixed.

You can check commits cc996fe and 08c1c08 for details on what I changed.

@et
Copy link
Author

et commented Nov 12, 2016

@urfolomeus - looks good! Hope you feel better! Thanks again for your work.

@zwhitchcox if you're going through the blog tutorial, make sure you note that signals (Part 7, Part 8, Part 11) have to be converted to subscriptions with elm 0.17.

@urfolomeus
Copy link
Contributor

Thanks @et. Getting there!

I've done a quick review of the remaining posts and my plan now is as follows:

7 - leave as is with a deprecation notice saying that Elm has now pushed Signals into the background and so I won't be updating them
8 - modify to use Html.App.Program rather than StartApp.start. I hope to get that done this coming week.
9 - skip for now
10 - this post is just about updating to 0.16 and so no longer relevant
11 - completely rewrite to use elm-phoenix-socket as per suggestion from @crenwick in CultivateHQ/seat_saver#15. This will take me longer to do but hopefully not too long (touch wood!). You can refer to @crenwick's solution in the meantime.

@zwhitchcox
Copy link

Sorry to hear you're not feeling well! Thanks for the alternative repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants