Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic.concat (keep = average) :: bug #738

Open
daniel-caichac-DHI opened this issue Nov 1, 2024 · 5 comments
Open

generic.concat (keep = average) :: bug #738

daniel-caichac-DHI opened this issue Nov 1, 2024 · 5 comments

Comments

@daniel-caichac-DHI
Copy link
Collaborator

Describe the bug
Hi.

I have 2 dfs2 files, hourly data, overlap by at least 80% of the time.
I can do mikeio.generic.concat(files, keep = 'first') and it works
also mikeio.generic.concat(files, keep = 'last') and it works
but when I do
mikeio.generic.concat(files, keep = 'average') I get this error
image

I am certain that there is no gap in time :(

To Reproduce
mikeio.generic.concat(files, keep = 'average')

Include code snippet

Expected behavior
Concat.

Screenshots
If applicable, add screenshots to help explain your problem.

System information:

  • Python version : 3.10
  • MIKE IO version : 2.1.0
@daniel-caichac-DHI daniel-caichac-DHI changed the title generic.concat (keep = average) generic.concat (keep = average) - bug Nov 1, 2024
@daniel-caichac-DHI daniel-caichac-DHI changed the title generic.concat (keep = average) - bug generic.concat (keep = average) :: bug Nov 1, 2024
@ecomodeller
Copy link
Member

@daniel-caichac-DHI this is a great opportunity for you to climb higher on the list of contributors😉

@daniel-caichac-DHI
Copy link
Collaborator Author

I have been trying to manually set the values of my mikeio.Datarray with a custom averaging function but it keeps not-working :)
Let me try to find the bug

@daniel-caichac-DHI
Copy link
Collaborator Author

image

I cannot push anyway

@ecomodeller
Copy link
Member

image

I cannot push anyway

Fixed, now you have write access!

@daniel-caichac-DHI
Copy link
Collaborator Author

See #739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants