Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Browse By Tabs on Community/Collection Homepages are missing ARIA labels. #2700

Closed
tdonohue opened this issue Dec 6, 2023 · 3 comments · Fixed by #2722
Closed
Assignees
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Collection Collection display or editing component: Community Community display or editing medium priority
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented Dec 6, 2023

Originally reported in #1178 as part of the Deque Analysis in 2021. This was rated as "serious" by Deque (one level down from "critical") which means:

Serious: This issue results in serious barriers for people with disabilities, and will partially prevent them from accessing fundamental features or content. People relying on assistive technologies will experience significant frustration as a result. Issues falling under this category are major problems, and remediation should be a priority.

Describe the bug

This issue impacts both the Community and Collection homepages:

  • (ID 469552, 469655) "Selected state of the element is missing or incorrect." on the currently selected browse by option (e.g. "Subcommunities and Collections" on Community homepage, "Recent Submission" on Collection homepage). In both cases, the selected option is displayed visually, but not noted in ARIA tags.
    • Fix: Use the aria-current attribute to indicate the element that represents the current item within a container or set of related elements, such as the currently selected page, step, location, date, or time. https://www.w3.org/TR/wai-aria-1.1/#aria-current

To Reproduce
Steps to reproduce the behavior:

  1. Can be reproduced on the demo site with these sample communities/collections:
  2. When on either of those pages, verify that the Browse By tabs (under Collection/Community page title) do not have aria-current attributes.

Related work
Originally reported in #1178

@tdonohue tdonohue added bug help wanted Needs a volunteer to claim to move forward accessibility good first issue This is a smaller ticket/bug that may be easier for new contributors medium priority component: Community Community display or editing component: Collection Collection display or editing labels Dec 6, 2023
@alexandrevryghem
Copy link
Member

Atmire would like to claim this issue

@tdonohue
Copy link
Member Author

tdonohue commented Dec 6, 2023

@alexandrevryghem : Sounds great! Assigning to you then for you (or whoever you delegate to) to work on.

@tdonohue tdonohue added claimed: Atmire Atmire team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Dec 6, 2023
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Feb 13, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone Feb 13, 2024
@tdonohue
Copy link
Member Author

tdonohue commented Feb 13, 2024

Ported to 7.6.x in #2800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Collection Collection display or editing component: Community Community display or editing medium priority
Projects
Development

Successfully merging a pull request may close this issue.

2 participants