Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model classes should not contain any logic #2874

Closed
alexandrevryghem opened this issue Mar 22, 2024 · 0 comments · Fixed by #2875
Closed

Model classes should not contain any logic #2874

alexandrevryghem opened this issue Mar 22, 2024 · 0 comments · Fixed by #2875
Assignees
Milestone

Comments

@alexandrevryghem
Copy link
Member

Describe the bug
Currently some components have methods in their classes. This can cause issues when nested object are copied from the SSR cache to the CSR cache. We recently had this happen for the MetadataValue model class. This can easily be fixed by moving that logic to a service and calling that service with the object instead.

Expected behavior
Those methods should be moved out of these model classes into new/existing services

@alexandrevryghem alexandrevryghem added bug needs triage New issue needs triage and/or scheduling labels Mar 22, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 22, 2024
@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label May 8, 2024
@tdonohue tdonohue moved this from 🆕 Triage to 🙋 Needs Help / Unscheduled in DSpace Backlog May 8, 2024
@github-project-automation github-project-automation bot moved this from 🙋 Needs Help / Unscheduled to ✅ Done / Closed in DSpace Backlog May 8, 2024
@tdonohue tdonohue removed this from DSpace Backlog May 8, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 8, 2024
@github-project-automation github-project-automation bot moved this to 📋 To Do in DSpace 8.0 Release May 8, 2024
@tdonohue tdonohue moved this from 📋 To Do to ✅ Done in DSpace 8.0 Release May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants