Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System-wide alert shouldn't be created when the message is empty #2876

Closed
alexandrevryghem opened this issue Mar 23, 2024 · 0 comments · Fixed by #2877
Closed

System-wide alert shouldn't be created when the message is empty #2876

alexandrevryghem opened this issue Mar 23, 2024 · 0 comments · Fixed by #2877
Assignees
@alexandrevryghem
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back needs triage New issue needs triage and/or scheduling

Comments

@alexandrevryghem
Copy link
Member

Describe the bug
When you don't have any system wide alerts (an empty systemwidealert table in the DB) and you click on the activate button before filling the message, an empty system-wide alert is shown and can't be deactivated until you fill in a message.

To Reproduce
Steps to reproduce the behavior:

  1. Delete all the system-wide alerts if you have any (DELETE FROM systemwidealert;)
  2. Click on the activate button
  3. Click on the same button again

Expected behavior
The system-wide alert should not be created with an empty message
@alexandrevryghem alexandrevryghem added bug needs triage New issue needs triage and/or scheduling claimed: Atmire Atmire team is working on this issue & will contribute back labels Mar 23, 2024
@alexandrevryghem alexandrevryghem self-assigned this Mar 23, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 23, 2024
@alexandrevryghem alexandrevryghem mentioned this issue Mar 23, 2024
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done / Closed in DSpace Backlog Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandrevryghem alexandrevryghem

Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back needs triage New issue needs triage and/or scheduling
Projects
DSpace Backlog
Status: ✅ Done / Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

System-wide alert shouldn't be created when the message is empty alexandrevryghem/dspace-angular
1 participant
@alexandrevryghem