MenuItemModel lacks text and link properties

[otuoma]

Describe the bug

In strongly typed typescript setups, using the properties 'link' and 'text' on instances of MenuItemModel fails with the following error

  Object literal may only specify known properties, and 'text' does not exist in type 'MenuItemModel'.

To Reproduce

Steps to reproduce the behavior:

1. Use with the example below

@Component({
  selector: 'ds-navbar',
  styleUrls: ['./navbar.component.scss'],
  templateUrl: './navbar.component.html',
  animations: [slideMobileNav]
})
export class NavbarComponent extends BaseComponent implements OnInit {
  scholarsMenu: MenuSection = {
    id: 'scholars_menu',
    visible: true,
    active: false,
    model: { type: MenuItemType.LINK, disabled: false, text: 'Scholar Profiles', link: '/communities/fb79-513', },
    index: 0,
    shouldPersistOnRouteChange: true,
  };

  ngOnInit() {
    super.ngOnInit();
    this.menuService.addSection(this.menuID, this.scholarsMenu);
  }
}

Expected behavior

All properties should be defined on the model interface

Related work

I have created a PR #3750

[otuoma]

Sorry @tdonohue, it's my first PR here. What am I supposed do at this stage?

[tdonohue]

@otuoma : At this stage, your PR has made it onto our Project Board (https://github.com/orgs/DSpace/projects/31) and is waiting on a volunteer to review it. So, there's nothing for you to do but be patient. Please do keep in mind though that we have a backlog of reviews currently (and it's the end of the year) so, unfortunately, it may be a while until a volunteer is able to review your work.

If you wanted to try to speed up the process, you are also allowed to ask a different developer if they would be willing to trade reviews (where you would review/test one of their PRs in exchange for them reviewing/testing yours). See https://wiki.lyrasis.org/display/DSPACE/Trading+reviews+on+Pull+Requests

[tdonohue]

As noted in the PR (see this comment), we discovered this was not a bug. Instead, the issue was caused by slightly incorrect code.

In order to specify a MenuItemType.LINK you MUST use LinkMenuItemModel like this:

model: { type: MenuItemType.LINK, disabled: false, text: 'Scholar Profiles', link: '/communities/fb79-513', } as LinkMenuItemModel,

The above code example (in the issue description) had accidentally left off the as LinkMenuItemModel, which is why the error was occurring.