Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search component shows loading component when results are already cached #3869

Open
ybnd opened this issue Jan 20, 2025 · 1 comment
Open
Assignees
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system

Comments

@ybnd
Copy link
Member

ybnd commented Jan 20, 2025

Describe the bug

A loading animation is always displayed when reloading search results, even if they are already cached.
This looks jarring as the whole page is replaced twice in short succession.

To Reproduce

Steps to reproduce the behavior:

  1. Open the network tab in your browser
  2. Go to the search page
  3. Select any filter from the sidebar
    • You will see a loading animation as the search request is being processed
    • The search results will update to match once it's done
  4. Deselect the filter
    • No request will be made, as the search results are cached
    • You will still see the loading animation for a fraction of a second

Expected behavior

When the search results are already cached, they should be displayed instantly without a loading animation in between

Related work

More noticeable after #3709

@ybnd ybnd added bug needs triage New issue needs triage and/or scheduling labels Jan 20, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Jan 20, 2025
@ybnd
Copy link
Member Author

ybnd commented Jan 21, 2025

@alexandrevryghem mentioned he may have found a fix for this already, so we'd like to claim it

@ybnd ybnd added the claimed: Atmire Atmire team is working on this issue & will contribute back label Jan 21, 2025
@tdonohue tdonohue added component: Discovery related to discovery search or browse system and removed needs triage New issue needs triage and/or scheduling labels Jan 21, 2025
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants