From 2e3c262f5641c75cd75b7caeee6602c1efbd2de6 Mon Sep 17 00:00:00 2001 From: Josh Ladieu Date: Wed, 1 Nov 2023 10:43:19 -0400 Subject: [PATCH] Put retries back the way they were. I temporarily knocked retry durations down to 1 second which turned a 7-minute test runtime to a 30-second test runtime. This was a temporary measure which I found helpful to accelerate iteration on failing tests. --- .../java/bio/terra/workspace/service/policy/TpsRetry.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/service/src/main/java/bio/terra/workspace/service/policy/TpsRetry.java b/service/src/main/java/bio/terra/workspace/service/policy/TpsRetry.java index 7eb2bdc13e..1b0b07efd6 100644 --- a/service/src/main/java/bio/terra/workspace/service/policy/TpsRetry.java +++ b/service/src/main/java/bio/terra/workspace/service/policy/TpsRetry.java @@ -20,9 +20,9 @@ public class TpsRetry { // The retry function starts with INITIAL_WAIT between retries, and doubles that until it // reaches MAXIMUM_WAIT, after which all retries are MAXIMUM_WAIT apart. - private static final Duration MAXIMUM_WAIT = Duration.ofSeconds(1); - private static final Duration INITIAL_WAIT = Duration.ofSeconds(1); - private static final Duration OPERATION_TIMEOUT = Duration.ofSeconds(1); + private static final Duration MAXIMUM_WAIT = Duration.ofSeconds(30); + private static final Duration INITIAL_WAIT = Duration.ofSeconds(10); + private static final Duration OPERATION_TIMEOUT = Duration.ofSeconds(300); // Tps calls which timeout will throw ApiExceptions wrapping SocketTimeoutExceptions and will have // an errorCode 0. This isn't a real HTTP status code, but we can check for it anyway.