Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need the class SeriesIdResolver? #106

Open
taojing2002 opened this issue Jun 26, 2024 · 0 comments
Open

Do we need the class SeriesIdResolver? #106

taojing2002 opened this issue Jun 26, 2024 · 0 comments
Milestone

Comments

@taojing2002
Copy link
Collaborator

In the SeriesIdResolver class, the method public static Identifier getPid(Identifier identifier) is used to get the Head identifier of a SID. The implementation of the method is to use the DataONE api call getSystemMetadata to get the Head identifier and it is hard to be replaced by Hashstore.
This method is only called in the class of ForesiteResourceMap. If we decide there are no SID in the resource map file, we may not need the method of SeriedsIdResolver.getPid at all.

@taojing2002 taojing2002 added this to the 3.1.0 milestone Jun 26, 2024
@artntek artntek modified the milestones: 3.1.0, 3.2.0 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants